[nanvix] .nanvix/setup_local: split POSIX-wrapper modules into their own section#747
Open
esaurez wants to merge 1 commit into
Open
Conversation
Previously _asyncio, _datetime, select, _socket, _posixsubprocess, fcntl, and termios sat under the 'Modules with bundled-in-cpython C deps' section header, which is misleading -- none of them bundle a vendored .a; they are thin POSIX/syscall wrappers (plus _asyncio / _datetime) whose libc / libm symbols resolve against python.elf's .dynsym at dlopen time via --export-dynamic. Move them into a dedicated 'POSIX syscall wrappers + concurrency primitives' section that mirrors upstream Setup.stdlib.in's 'Modules with some UNIX dependencies' grouping. Purely cosmetic -- no change to the generated Setup.local except entry order within the *shared* block (which makesetup does not depend on; each module name still appears at most once). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
_asyncio,_datetime,select,_socket,_posixsubprocess,fcntl, andtermiosout of the "Modules with bundled-in-cpython C deps" section in.nanvix/setup_local.pyand into a dedicated "POSIX syscall wrappers + concurrency primitives" section. The old grouping was misleading: none of these bundle a vendored.a; they are thin POSIX/syscall wrappers (plus_asyncio/_datetime) whose libc / libm symbols resolve againstpython.elf's.dynsymatdlopentime via--export-dynamic. The new section mirrors upstreamModules/Setup.stdlib.in's "Modules with some UNIX dependencies" grouping.Purely cosmetic: no change to the generated
Setup.localexcept entry order within the*shared*block (which makesetup does not depend on; each module name still appears at most once).Validated with
./z lint.Dependencies
Must merge after nanvix/cpython#739, the base it branches from: it reorders the
setup_local.pyentries that #739 populates, so it has to sit on top of #739's version of the file. Independent of the three sibling cleanups that share the same base -- #745 (drop dead Makefile variables), #746 (drop deadconfig.pyhelpers), and #748 (enableinet_pton) -- which touch different files, so the four can merge in any order.