[nanvix] .nanvix/config: drop dead toolchain_paths / configure_env helpers#746
Open
esaurez wants to merge 1 commit into
Open
[nanvix] .nanvix/config: drop dead toolchain_paths / configure_env helpers#746esaurez wants to merge 1 commit into
esaurez wants to merge 1 commit into
Conversation
Both helpers are unused: the actual cpython build invokes `make -f Makefile.nanvix` which has its own inline CONFIGURE_ENV authoritative for CC / CFLAGS / LDFLAGS / LIBS. The dead Python copies had drifted to stale pre-Wave-7 link flags (literal -lsqlite3 -lz -lbz2 -llzma in LIBS, no DT_NEEDED awareness) and would have mis-built any caller that picked them up. Keep configure_opts() (still called from build.py) and the toolchain / docker path constants (referenced elsewhere). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
toolchain_paths()andconfigure_env()helpers from.nanvix/config.py. The cpython build invokesmake -f Makefile.nanvix, which has its own inlineCONFIGURE_ENVthat is authoritative forCC/CFLAGS/LDFLAGS/LIBS; these Python helpers are never called. They had also drifted to stale link flags (literal-lsqlite3 -lz -lbz2 -llzmainLIBS, with no DT_NEEDED awareness), so any caller that did pick them up would mis-build.configure_opts()(still called frombuild.py) and the toolchain / docker path constants are kept.Validated with
./z lint.Dependencies
Merges after nanvix/cpython#739, the base it branches from, but the removed helpers are already unused, so this is functionally independent of #739's contents. Independent of the three sibling cleanups that share the same base -- #745 (drop dead Makefile variables), #747 (split
setup_localsections), and #748 (enableinet_pton) -- which touch different files, so the four can merge in any order.