[nanvix] Makefile.nanvix: drop dead LIBSSL/LIBCRYPTO/LIBZ/LIBSQLITE3 vars#745
Open
esaurez wants to merge 1 commit into
Open
[nanvix] Makefile.nanvix: drop dead LIBSSL/LIBCRYPTO/LIBZ/LIBSQLITE3 vars#745esaurez wants to merge 1 commit into
esaurez wants to merge 1 commit into
Conversation
After Wave 5's Group-A unbundling these per-library .a path variables are no longer referenced anywhere -- the build now picks up libssl / libcrypto / libz / libsqlite3 via -l<name> against the .so siblings in $(SYSROOT)/lib/. Removing the unused definitions makes it harder to accidentally reintroduce static linking by referencing one of them in a future LIBS rewrite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
LIBSSL/LIBCRYPTO/LIBZ/LIBSQLITE3make variables fromMakefile.nanvix. These per-library.apath variables are no longer referenced anywhere: the build linkslibssl/libcrypto/libz/libsqlite3via-l<name>against the.sosiblings in$(SYSROOT)/lib/. Dropping the dead definitions removes a footgun -- referencing one of them in a futureLIBSrewrite would silently reintroduce static linking of a library that is meant to be loaded as a shared object.Validated with
./z lint.Dependencies
Must merge after nanvix/cpython#739, the base it branches from: the four variables only become unused once
_ssl/_hashlib/zlib/_sqlite3are moved to DT_NEEDED.so(completed by #739), so removing them earlier would break the link. Independent of the three sibling cleanups that share the same base -- #746 (drop deadconfig.pyhelpers), #747 (splitsetup_localsections), and #748 (enableinet_pton, which also editsMakefile.nanvixbut a disjoint region) -- so the four can merge in any order.