ctap2.3: long-touch reset (§6.11.5, §7.7)#69
Conversation
| /// User interface that returns a static value for the user presence check. | ||
| struct TestUI { | ||
| user_presence: Level, | ||
| } |
There was a problem hiding this comment.
@0x0ece I’ve included this change that replaces TestUp with a UserInterface implementation that returns a static value for discussion. The benefit is that we use the normal UP path through trussed (and also return the correct error code!), the downside is that the test has to wait for the user presence timeout of 30s. If we want to go that way, we could make the timeout configurable so that tests can reduce it to e. g. 1s. What do you think?
There was a problem hiding this comment.
config timeout might be a good idea, I just re-looked at the spec and they say "MUST be at least 10 seconds". so yeah, like we put it 1s for unit tests, leave it 30s for authenticator, and it's still a feature that someone else can tune.
There was a problem hiding this comment.
Okay, I’ve added the option and set it to 100 ms for the tests.
robin-nitrokey
force-pushed
the
long-touch
branch
from
a0ef4bb to
88841da
Compare
robin-nitrokey
force-pushed
the
long-touch
branch
from
88841da to
4bd3629
Compare
2 participants
Cherry-picked from #60 and slightly modified to fix the
get_inforesponse and to improve the check for supported commands inconfig.