virt: Simplify UserInterface struct#231
Merged
Merged
Conversation
0x0ece
approved these changes
Jun 8, 2026
In practice, the impl Into only makes things more complicated because type inference does not work and users need to add type annotations: https://github.com/trussed-dev/fido-authenticator/blob/4bd3629b6695c10152796f9e9d5d5f9583b43a6a/tests/virt/mod.rs#L327 So we can also just pass the box directly.
This makes it easier to test different user presence levels without having to implement the full UserInterface trait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two ergonomic problems with the
virt::UserInterfacestruct that we saw in trussed-dev/fido-authenticator#69:impl Into<...>wrapper forUserInterface::set_innerdoes not work as expected. Callers have to add type annotations to make it work, so it is easier to just pass the box directly.UserInterfacetrait. This PR adds aUserInterface::set_user_presence_levelmethod to override the defaultLevel::Normal.