SG-43626 Fix bug when details panel collapses/expands#142
Merged
carlos-villavicencio-adsk merged 2 commits intoJun 10, 2026
Merged
Conversation
carlos-villavicencio-adsk
force-pushed
the
ticket/SG-43626_collapse_details_bug
branch
from
9280df7 to
01a191c
Compare
carlos-villavicencio-adsk
merged commit 167d05b
into
ticket/SG-43460_migration_4
9 of 24 checks passed
carlos-villavicencio-adsk
deleted the
ticket/SG-43626_collapse_details_bug
branch
carlos-villavicencio-adsk
added a commit
that referenced
this pull request
Jun 10, 2026
* Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes * Migrate template helpers * Code review feedback * Update setting name * Change MEDM to FlowAM in comments * Replace MEDM in log messages * SG-43626 Fix bug when details panel collapses/expands (#142) * Fix bug when details panel collapses/expands * SG-43627 Fix empty space gap on the details panel (#143)
carlos-villavicencio-adsk
added a commit
that referenced
this pull request
Jun 10, 2026
* Migrate config hooks * Add type annotations * Wrap `get_am_base_obj` into the loader action manager * Wraps constant * SG-43460 [Part4] Build dialogs and template utils (#140) * Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes * Migrate template helpers * Code review feedback * Update setting name * Change MEDM to FlowAM in comments * Replace MEDM in log messages * SG-43626 Fix bug when details panel collapses/expands (#142) * Fix bug when details panel collapses/expands * SG-43627 Fix empty space gap on the details panel (#143)
carlos-villavicencio-adsk
added a commit
that referenced
this pull request
Jun 10, 2026
* Migration of the MEDM resources * Migration of MEDM core logic * Fix thumbnail display on version history * Tentative wrap-up * Format * Fix CI: add missing fw * Update Azure pipelines additional_repositories * Revert framework additions for CI * Comment framework for CI * Test CI green * Add remaining types * Fix types * Code review feedback * Move `DRAFT_VERSION_IDENTIFIER` to constants * SG-43458 [Part3] Config Hooks (#139) * Migrate config hooks * Add type annotations * Wrap `get_am_base_obj` into the loader action manager * Wraps constant * SG-43460 [Part4] Build dialogs and template utils (#140) * Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes * Migrate template helpers * Code review feedback * Update setting name * Change MEDM to FlowAM in comments * Replace MEDM in log messages * SG-43626 Fix bug when details panel collapses/expands (#142) * Fix bug when details panel collapses/expands * SG-43627 Fix empty space gap on the details panel (#143)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base branch: #140
The bug:
DeleteWhenStoppedmakes Qt destroy the C++ animation object when it finishes, butself._current_animationstill holds the dead Python wrapper. On the next toggle, .state() crashes on the deleted object.Fix: connect finished to clear
self._current_animation, so the guard ifself._current_animationbecomes False after it's gone.When the animation finishes, Qt deletes the C++ object and the finished signal fires — clearing self._current_animation to None before anything can touch the dead wrapper again.