Skip to content

SG-43627 Fix empty space gap on the details panel#143

Merged
carlos-villavicencio-adsk merged 1 commit into
ticket/SG-43626_collapse_details_bugfrom
ticket/SG-43627_fix_details_whitespace
Jun 10, 2026
Merged

SG-43627 Fix empty space gap on the details panel#143
carlos-villavicencio-adsk merged 1 commit into
ticket/SG-43626_collapse_details_bugfrom
ticket/SG-43627_fix_details_whitespace

Conversation

@carlos-villavicencio-adsk

Copy link
Copy Markdown
Contributor

Base branch: #142

Empty gap below versions list - history_view had a hardcoded minimumHeight: 350 in the UI file, forcing it to always occupy 350px regardless of content. Removed this constraint and switched the size policy to Preferred so the existing dynamic sizing code (_patch_history_view_sizing / _update_history_view_height) could actually take effect. _update_history_view_height was also updated to call setMaximumHeight directly rather than relying on updateGeometry alone, which Qt treats as advisory.

The change only affects the .ui file, but the rest of the files are generated by build resources script.

@chenm1adsk chenm1adsk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! but please remember resolve the failing checks :)

@carlos-villavicencio-adsk carlos-villavicencio-adsk merged commit 80fcf57 into ticket/SG-43626_collapse_details_bug Jun 10, 2026
12 of 25 checks passed
@carlos-villavicencio-adsk carlos-villavicencio-adsk deleted the ticket/SG-43627_fix_details_whitespace branch June 10, 2026 18:40
carlos-villavicencio-adsk added a commit that referenced this pull request Jun 10, 2026
* Fix bug when details panel collapses/expands

* SG-43627 Fix empty space gap on the details panel (#143)
carlos-villavicencio-adsk added a commit that referenced this pull request Jun 10, 2026
* Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes

* Migrate template helpers

* Code review feedback

* Update setting name

* Change MEDM to FlowAM in comments

* Replace MEDM in log messages

* SG-43626 Fix bug when details panel collapses/expands (#142)

* Fix bug when details panel collapses/expands

* SG-43627 Fix empty space gap on the details panel (#143)
carlos-villavicencio-adsk added a commit that referenced this pull request Jun 10, 2026
* Migrate config hooks

* Add type annotations

* Wrap `get_am_base_obj` into the loader action manager

* Wraps constant

* SG-43460 [Part4] Build dialogs and template utils (#140)

* Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes

* Migrate template helpers

* Code review feedback

* Update setting name

* Change MEDM to FlowAM in comments

* Replace MEDM in log messages

* SG-43626 Fix bug when details panel collapses/expands (#142)

* Fix bug when details panel collapses/expands

* SG-43627 Fix empty space gap on the details panel (#143)
carlos-villavicencio-adsk added a commit that referenced this pull request Jun 10, 2026
* Migration of the MEDM resources

* Migration of MEDM core logic

* Fix thumbnail display on version history

* Tentative wrap-up

* Format

* Fix CI: add missing fw

* Update Azure pipelines additional_repositories

* Revert framework additions for CI

* Comment framework for CI

* Test CI green

* Add remaining types

* Fix types

* Code review feedback

* Move  `DRAFT_VERSION_IDENTIFIER`  to constants

* SG-43458 [Part3] Config Hooks (#139)

* Migrate config hooks

* Add type annotations

* Wrap `get_am_base_obj` into the loader action manager

* Wraps constant

* SG-43460 [Part4] Build dialogs and template utils (#140)

* Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes

* Migrate template helpers

* Code review feedback

* Update setting name

* Change MEDM to FlowAM in comments

* Replace MEDM in log messages

* SG-43626 Fix bug when details panel collapses/expands (#142)

* Fix bug when details panel collapses/expands

* SG-43627 Fix empty space gap on the details panel (#143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants