SG-43460 [Part4] Build dialogs and template utils#140
Merged
carlos-villavicencio-adsk merged 7 commits intoJun 10, 2026
Merged
Conversation
carlos-villavicencio-adsk
force-pushed
the
ticket/SG-43458_migration_3
branch
from
740e96f to
34a1de9
Compare
carlos-villavicencio-adsk
force-pushed
the
ticket/SG-43460_migration_4
branch
from
25fdeb0 to
4ae7184
Compare
carlos-villavicencio-adsk
force-pushed
the
ticket/SG-43460_migration_4
branch
from
4ae7184 to
e5f8388
Compare
chenm1adsk
reviewed
Jun 3, 2026
| self.ui.templateWidget.setVisible(is_template_mode) | ||
| self.ui.pipeline_step_combo_box.clear() | ||
|
|
||
| if is_template_mode and self.step: |
There was a problem hiding this comment.
We should call self.get_pipeline_steps() here as well, otherwise self.pipeline_steps is always empty and will cause issue when later we try to pipeline_step = self.pipeline_steps[step] in get_pipeline_step_templates()
Contributor
Author
There was a problem hiding this comment.
I don't think this is something we should worry about. I've been logging this scenario, and self.step is mostly None all the time, and self.pipeline_steps can be {}.
| self.ok_button = self.ui.build_template_button_box.button( | ||
| QtGui.QDialogButtonBox.Ok | ||
| ) | ||
| self.ok_button.clicked.disconnect() |
There was a problem hiding this comment.
Claude give me this suggestion but I am not sure if it is correct, could you please double check?
ok_button.clicked has no Python-side slots connected, so disconnect() raises
RuntimeError. The internal Qt connection from ok_button.clicked to
button_box.accepted() is managed in C++ and invisible to Python. Fix:
disconnect button_box.accepted instead:
self.ui.build_template_button_box.accepted.disconnect()
Contributor
Author
There was a problem hiding this comment.
I don't think we should worry about this.
* Fix bug when details panel collapses/expands * SG-43627 Fix empty space gap on the details panel (#143)
carlos-villavicencio-adsk
merged commit 62f361b
into
ticket/SG-43458_migration_3
9 of 24 checks passed
carlos-villavicencio-adsk
added a commit
that referenced
this pull request
Jun 10, 2026
* Migrate config hooks * Add type annotations * Wrap `get_am_base_obj` into the loader action manager * Wraps constant * SG-43460 [Part4] Build dialogs and template utils (#140) * Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes * Migrate template helpers * Code review feedback * Update setting name * Change MEDM to FlowAM in comments * Replace MEDM in log messages * SG-43626 Fix bug when details panel collapses/expands (#142) * Fix bug when details panel collapses/expands * SG-43627 Fix empty space gap on the details panel (#143)
carlos-villavicencio-adsk
added a commit
that referenced
this pull request
Jun 10, 2026
* Migration of the MEDM resources * Migration of MEDM core logic * Fix thumbnail display on version history * Tentative wrap-up * Format * Fix CI: add missing fw * Update Azure pipelines additional_repositories * Revert framework additions for CI * Comment framework for CI * Test CI green * Add remaining types * Fix types * Code review feedback * Move `DRAFT_VERSION_IDENTIFIER` to constants * SG-43458 [Part3] Config Hooks (#139) * Migrate config hooks * Add type annotations * Wrap `get_am_base_obj` into the loader action manager * Wraps constant * SG-43460 [Part4] Build dialogs and template utils (#140) * Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes * Migrate template helpers * Code review feedback * Update setting name * Change MEDM to FlowAM in comments * Replace MEDM in log messages * SG-43626 Fix bug when details panel collapses/expands (#142) * Fix bug when details panel collapses/expands * SG-43627 Fix empty space gap on the details panel (#143)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base branch #139
Build dialogs
Migrate the code in the two custom UIs
And related utilities into tk-multi-loader2.