Skip to content

Remove ArenaCacheSelector for visible_parent_map query ( + LRC)#92169

Merged
bors merged 1 commit into
rust-lang:masterfrom
In-line:no-cache-selector-lrc
Jan 13, 2022
Merged

Remove ArenaCacheSelector for visible_parent_map query ( + LRC)#92169
bors merged 1 commit into
rust-lang:masterfrom
In-line:no-cache-selector-lrc

Conversation

@In-line

@In-line In-line commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 21, 2021
@rust-highfive

rust-highfive commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2021
@In-line

In-line commented Dec 21, 2021

Copy link
Copy Markdown
Contributor Author

Please, kindly schedule a perf run, in accordinness with #87349 (comment)

@In-line

In-line commented Dec 21, 2021

Copy link
Copy Markdown
Contributor Author

r? @Mark-Simulacrum

@In-line In-line mentioned this pull request Dec 21, 2021
Closed
@In-line In-line force-pushed the no-cache-selector-lrc branch from 8d43415 to 9a9c6a2 Compare December 21, 2021 18:39
@In-line
Remove ArenaCacheSelector for visible_parent_map query.
852dea8 
Optimize visible_parent_map to use LRC to prevent unnecessary cloning
@In-line In-line force-pushed the no-cache-selector-lrc branch from 9a9c6a2 to 852dea8 Compare December 21, 2021 18:40
@Aaron1011

Aaron1011 commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 21, 2021
@bors

bors commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 852dea8 with merge 4736b7cc664479bfe36f2802f887ae3513a3e47b...

@bors

bors commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 4736b7cc664479bfe36f2802f887ae3513a3e47b (4736b7cc664479bfe36f2802f887ae3513a3e47b)

@rust-timer

rust-timer commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

Queued 4736b7cc664479bfe36f2802f887ae3513a3e47b with parent e100ec5, future comparison URL.

@rust-timer

rust-timer commented Dec 22, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (4736b7cc664479bfe36f2802f887ae3513a3e47b): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 22, 2021
@Mark-Simulacrum

Mark-Simulacrum commented Jan 10, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 10, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 852dea8 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2022
This was referenced Jan 10, 2022
Closed
Closed
@cjgillot

cjgillot commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

What is the rationale behind this change?

@bors

bors commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 852dea8 with merge 9b107b3fef78ffbbbbcc36743b04ace5ce9db6db...

@bors

bors commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2022
@rust-log-analyzer

rust-log-analyzer commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v2' (SHA:ec3a7ce113134d7a93b817d10a8272cb61118579)
Download action repository 'rust-lang/simpleinfra@master' (SHA:319234335b2b458c8f653eec7ed3d6abe1f2e02f)
##[error]Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_ef7bcab4-0814-4f3a-be17-c135efe9c748/51d6c88b-71e2-4f41-b7d6-74faa5d7ecd1.tar.gz. return code: 2.

@Aaron1011

Aaron1011 commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2022
@bors

bors commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 852dea8 with merge 3e9ef3b966887c0eada1b2831aa817a4beebf561...

@bors

bors commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2022
@rust-log-analyzer

rust-log-analyzer commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@lqd

lqd commented Jan 12, 2022

Copy link
Copy Markdown
Member

@bors retry Looks like apple runner issues

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2022
@bors

bors commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 852dea8 with merge cf02e4761fb46fe68a1f695c6e20978636c2e4af...

@rust-log-analyzer

rust-log-analyzer commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors

bors commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2022
@ehuss

ehuss commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

@bors retry
dist-aarch64-apple error with no log

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2022
@bors

bors commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 852dea8 with merge 124555a...

@bors

bors commented Jan 13, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 124555a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 13, 2022
@bors bors merged commit 124555a into rust-lang:master Jan 13, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.