Skip to content

Optimize visible_parent_map to use LRC to prevent unnecessary cloning#92170

Closed
In-line wants to merge 1 commit into
rust-lang:masterfrom
In-line:cache-selector-lrc
Closed

Optimize visible_parent_map to use LRC to prevent unnecessary cloning#92170
In-line wants to merge 1 commit into
rust-lang:masterfrom
In-line:cache-selector-lrc

Conversation

@In-line

@In-line In-line commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 21, 2021
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2021
@In-line

In-line commented Dec 21, 2021

Copy link
Copy Markdown
Contributor Author

r? @Mark-Simulacrum

Please, kindly schedule a perf run, in accordinness with #87349 (comment)

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 21, 2021
@bors

bors commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 139e946 with merge cd95aa6bd6b91571b700b7d3f390c47d105237c8...

@bors

bors commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: cd95aa6bd6b91571b700b7d3f390c47d105237c8 (cd95aa6bd6b91571b700b7d3f390c47d105237c8)

@rust-timer

Copy link
Copy Markdown
Collaborator

Queued cd95aa6bd6b91571b700b7d3f390c47d105237c8 with parent 8ad3c1d, future comparison URL.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd95aa6bd6b91571b700b7d3f390c47d105237c8): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 22, 2021
@Mark-Simulacrum

Copy link
Copy Markdown
Member

Closing in favor of #92169.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants