Skip to content

Stabilize int_format_into feature#152544

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:stabilize-int_format_into
Jun 15, 2026
Merged

Stabilize int_format_into feature#152544
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:stabilize-int_format_into

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Feb 12, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 12, 2026
@rustbot

rustbot commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in integer formatting

cc @tgross35

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2026
@GuillaumeGomez GuillaumeGomez added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 84973ef to 03a0f20 Compare February 12, 2026 16:12
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 03a0f20 to 897eb89 Compare February 12, 2026 16:24
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 897eb89 to 2ec6387 Compare February 12, 2026 16:37
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jhpratt jhpratt mentioned this pull request Feb 20, 2026
Closed
4 tasks
Amanieu
Amanieu reviewed Mar 28, 2026
View reviewed changes
Comment thread library/core/src/fmt/num_buffer.rs
Comment thread library/core/src/fmt/num_buffer.rs Outdated
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 2ec6387 to 74ce864 Compare March 28, 2026 12:09
@rustbot

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 74ce864 to 28edb57 Compare March 28, 2026 12:10
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 28edb57 to f93c2e2 Compare March 28, 2026 13:13
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from f93c2e2 to ec80536 Compare March 28, 2026 18:04
GuillaumeGomez
GuillaumeGomez commented Mar 28, 2026
View reviewed changes
Comment thread library/core/src/fmt/num_buffer.rs
/// Returns the length of the internal buffer.
#[unstable(feature = "int_format_into", issue = "138215")]
pub const fn capacity(&self) -> usize {
pub(crate) const fn capacity(&self) -> usize {

@GuillaumeGomez GuillaumeGomez Mar 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the size of NumBuffer is always the same, we are forced to use this method until we can actually use the NumBufferTrat::BUF_SIZE when declaring NumBuffer.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from ec80536 to 789f4f2 Compare March 28, 2026 19:43
@GuillaumeGomez

GuillaumeGomez commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

Finally fixed CI. ^^'

@rust-bors

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 789f4f2 to 41d83dc Compare May 19, 2026 17:13
@rustbot

This comment has been minimized.

Sign in to view
@GuillaumeGomez

GuillaumeGomez commented May 19, 2026

Copy link
Copy Markdown
Member Author

FCP ended.

cc @joshtriplett

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 41d83dc to 4f14499 Compare May 19, 2026 21:02
@GuillaumeGomez

GuillaumeGomez commented May 20, 2026

Copy link
Copy Markdown
Member Author

Fixed CI. :)

@rust-bors

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from 4f14499 to c7f193f Compare May 21, 2026 12:43
@rustbot

rustbot commented May 21, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez

GuillaumeGomez commented May 21, 2026

Copy link
Copy Markdown
Member Author

Fixed merge conflict.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the stabilize-int_format_into branch from c7f193f to 1b5c239 Compare May 21, 2026 13:57
@GuillaumeGomez

GuillaumeGomez commented May 21, 2026

Copy link
Copy Markdown
Member Author

And fixed the doctest.

@Amanieu

Amanieu commented Jun 15, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

📋 This PR cannot be approved because it currently has the following label: needs-fcp.

@Amanieu Amanieu removed the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Jun 15, 2026
@Amanieu

Amanieu commented Jun 15, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1b5c239 has been approved by Amanieu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 15, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 15, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152544 - GuillaumeGomez:stabilize-int_forma…
571af09 
…t_into, r=Amanieu

Stabilize `int_format_into` feature

Fixes rust-lang#138215.

r? @Amanieu
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 15, 2026
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 15, 2026
@GuillaumeGomez
Rollup merge of rust-lang#152544 - GuillaumeGomez:stabilize-int_forma…
d930d30 
…t_into, r=Amanieu

Stabilize `int_format_into` feature

Fixes rust-lang#138215.

r? @Amanieu
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 15, 2026
Closed
@jhpratt jhpratt mentioned this pull request Jun 15, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 15, 2026
@bors
Auto merge of #157932 - jhpratt:rollup-OmNrNWw, r=jhpratt
01dfd79 
Rollup of 13 pull requests

Successful merges:

 - #152544 (Stabilize `int_format_into` feature)
 - #157507 (fixed: differentiation between uninitialized and possibly uninitialized)
 - #155750 (Document that `ManuallyDrop`'s `Box` interaction has been fixed)
 - #157075 (lower edition requirements for some async-closure test helpers)
 - #157627 (remove LLVM `va_end` calls)
 - #157660 (normalize instead of evaluating type const patterns)
 - #157692 (Don't emit `unused_parens` suggestion for proc-macro-synthesized parens around bounds)
 - #157908 (fix binding const argument to assoc type suggestion)
 - #157915 (scalable vecs size incl. num vecs + no sret for scalable vecs)
 - #157916 (Avoid ICE on invalid crate-level cfg_attr predicates)
 - #157919 (mention in the `extern "tail"` error that it's supported on x86)
 - #157920 (mailmap: add mu001999)
 - #157924 (Update books)
@rust-bors rust-bors Bot merged commit 04ba92b into rust-lang:main Jun 15, 2026
11 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 16, 2026
rust-timer added a commit that referenced this pull request Jun 16, 2026
@rust-timer
Unrolled build for #152544
3483708 
Rollup merge of #152544 - GuillaumeGomez:stabilize-int_format_into, r=Amanieu

Stabilize `int_format_into` feature

Fixes #138215.

r? @Amanieu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees

@Amanieu Amanieu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for integer formatting into a fixed-size buffer

4 participants

@GuillaumeGomez @rustbot @rust-log-analyzer @Amanieu