Rollup of 13 pull requests#157932
Merged
Merged
Conversation
it is not as important anymore (see next comment)
…uses Mentored-by: Usman Akinyemi <usmanakinyemi202@gmail.com> Signed-off-by: Dilshad Azam <azam.dilshad@gmail.com>
1. Simple type const 2. Inherent associated type const 3. Trait associated type const
The correct size for `Layout` of a scalable vector ought to include the number of vectors, otherwise we generate `memcpy` that do not copy the entire vector and things like that.
rustc typically uses a return area pointer if the size of a return value is larger than two pointers, except for SIMD vectors and now scalable vectors. Given the previous commit, scalable types are more likely to trigger this conditional than previously. This is already tested in the output of the `codegen-llvm/scalable-vectors/tuple-intrinsics.rs` test.
The operation is a no-op, so we skip it.
`poly_trait_ref.parens` only records that the parser saw parentheses around a trait-object/impl-trait bound; it does not guarantee that the bound's span actually points at those parentheses in the source. A proc-macro can synthesize the parentheses while reusing an unrelated span from its input, so the span may not be wrapped in parentheses at all. Previously the lint unconditionally trimmed the first and last byte of the span to build the "remove these parentheses" suggestion. On such reused spans this produced an invalid suggestion (e.g. rewriting a field `val: u8` to `al: u`) and could even ICE when the span started or ended on a multibyte character. Only emit the lint when the source text at the span really is wrapped in parentheses.
…t_into, r=Amanieu Stabilize `int_format_into` feature Fixes rust-lang#138215. r? @Amanieu
…initialized, r=estebank fixed: differentiation between uninitialized and possibly uninitialized Fix: rust-lang#157267
…r=jhpratt Document that `ManuallyDrop`'s `Box` interaction has been fixed Both rust-lang#150447 and rust-lang#150446 has been merged in `1.96.0`, fixing the unfortunate `ManuallyDrop<Box<_>>` behavior. cc @RalfJung
…, r=wesleywiser lower edition requirements for some async-closure test helpers
…alfJung remove LLVM `va_end` calls tracking issue: rust-lang#44930 The operation is a no-op, so we skip it.
…st-evaluation, r=BoxyUwU normalize instead of evaluating type const patterns closes: rust-lang#156409 Fixes: rust-lang/project-const-generics#116 r? @BoxyUwU
…-macro-span, r=mejrs Don't emit `unused_parens` suggestion for proc-macro-synthesized parens around bounds Supersedes rust-lang#157662, which got auto closed after I force pushed the branch and github won't let me reopen it. Fixes rust-lang#144378. When the unused_parens lint removes the parentheses around a trait bound, it assumed the bound's span starts and ends with those parentheses, so it just trimmed one byte off each end to build the suggestion. That isn't always true. A proc macro can give the bound a span that doesn't point at parentheses at all, and then trimming a byte produces a broken suggestion, or crashes when that byte lands in the middle of a multibyte character. So now we only remove the parens when the source text at that span actually starts with `(` and ends with `)`. That also handles the unicode parens case you mentioned, since `（` isn't an ASCII `(` and just gets skipped. I added a test that reproduces the crash with a proc macro. r? @mejrs
fix binding const argument to assoc type suggestion r? fmease fixes rust-lang#151602
…um-vectors, r=lqd scalable vecs size incl. num vecs + no sret for scalable vecs The correct size for `Layout` of a scalable vector ought to include the number of vectors, otherwise we generate `memcpy` that do not copy the entire vector and things like that. This is tested in `ui/scalable-vectors/layout.rs`. Additionally, rustc typically uses a return area pointer if the size of a return value is larger than two pointers, except for SIMD vectors and now scalable vectors. Given the previous change, scalable types are more likely to trigger this conditional than previously. This is already tested in the output of the `codegen-llvm/scalable-vectors/tuple-intrinsics.rs` test. r? @lqd
…cate-ice, r=JonathanBrouwer Avoid ICE on invalid crate-level cfg_attr predicates Fixes rust-lang#157892
mention in the `extern "tail"` error that it's supported on x86 rust-lang#157016 (comment) r? folkertdev @bors rollup
mailmap: add mu001999 Add new email addresses in the mailmap. I think self reviews are OK for this kind of change, so r? me
Update books ## rust-lang/reference 2 commits in 01b0ee707f4571e803c8b2c471d8335a448f5d60..2c27905c15a51983b54d84f050d3bda096194d27 2026-06-15 14:08:07 UTC to 2026-06-08 16:22:03 UTC - undefined: fix typo (rust-lang/reference#2285) - Document RISC-V d, e, and f extensions (rust-lang/reference#2274)
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
rustbot
removed
the
S-waiting-on-review
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 42d7d52 (parent) -> 01dfd79 (this PR) Test differencesShow 313 test diffsStage 1
Stage 2
Additionally, 282 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 01dfd79246f1b2d5f146616deff08223a840a9ae --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 42d7d52920 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jun 16, 2026
Collaborator
|
Finished benchmarking commit (01dfd79): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (secondary 41.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 518.288s -> 519.231s (0.18%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
int_format_intofeature #152544 (Stabilizeint_format_intofeature)ManuallyDrop'sBoxinteraction has been fixed #155750 (Document thatManuallyDrop'sBoxinteraction has been fixed)va_endcalls #157627 (remove LLVMva_endcalls)unused_parenssuggestion for proc-macro-synthesized parens around bounds #157692 (Don't emitunused_parenssuggestion for proc-macro-synthesized parens around bounds)extern "tail"error that it's supported on x86 #157919 (mention in theextern "tail"error that it's supported on x86)r? @ghost
Create a similar rollup