docs: correct OWNCLOUD_HTTP2_ENABLED default#764
Conversation
The default was documented as "depends on Qt version". In client 7.1 HTTP2 is force-disabled by default: the flag is set only when the variable equals "1", so any other value (including unset) disables it. There is no Qt-version branching. Source: src/libsync/accessmanager.cpp:95-98. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Review: correct
|
dj4oC
left a comment
There was a problem hiding this comment.
Corrects the documented default for OWNCLOUD_HTTP2_ENABLED from "depends on Qt version" to "0 (disabled)", matching the master/7.1 pair (#763).
Findings
Nothing blocking. The table edit is AsciiDoc-valid and internally consistent with the paired 7.1 PR. Note: owncloud/client (the cited source for accessmanager.cpp:95-98) is outside this review agent's repo scope, so the source citation itself isn't independently re-verified here — the diff is otherwise clean.
Verdict
Approved
🤖 Automated review by Claude Code
Generated by Claude Code
master counterpart of #763. HTTP2 is force-disabled by default in client 7.1 (flag set only when the variable equals "1"); the docs said "depends on Qt version". Source:
src/libsync/accessmanager.cpp:95-98.🤖 Generated with Claude Code