docs: correct OWNCLOUD_HTTP2_ENABLED default (7.1)#763
Conversation
The default was documented as "depends on Qt version". In client 7.1 HTTP2 is force-disabled by default: the flag is set only when the variable equals "1", so any other value (including unset) disables it. There is no Qt-version branching. Source: src/libsync/accessmanager.cpp:95-98. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Review: correct
|
dj4oC
left a comment
There was a problem hiding this comment.
7.1 counterpart of #764 — corrects the documented default for OWNCLOUD_HTTP2_ENABLED from "depends on Qt version" to "0 (disabled)".
Findings
Nothing blocking. Diff is byte-identical to the master PR (#764), targets the 7.1 base correctly, and is AsciiDoc-valid. Same scope caveat as #764: the owncloud/client source citation isn't independently re-verified here (out of this agent's repo scope).
Verdict
Approved
🤖 Automated review by Claude Code
Generated by Claude Code
Summary
The documented default for
OWNCLOUD_HTTP2_ENABLEDwas "depends on Qt version". In client 7.1 HTTP2 is force-disabled by default: the attribute is set toqEnvironmentVariableIntValue("OWNCLOUD_HTTP2_ENABLED") == 1, so anything other than"1"(including unset) leaves HTTP2 disabled. There is no Qt-version branching.Updates the Default column to
0 (disabled)and clarifies it must be force-enabled with"1"(and still requires server support).Source of truth
owncloud/client@7.1:src/libsync/accessmanager.cpp:95-98.🤖 Generated with Claude Code