docs: correct UI labels in using.adoc#760
Conversation
Several control labels did not match client 7.1: - "Launch on System Startup" -> "Start on Login" (generalsettings.ui:55) - activity "Copy to clipboard" -> "Copy" (commonstrings.cpp:44) - activity "Show file in browser" -> "Show in <file manager>" (commonstrings.cpp:32-34; distinct from "Show in web browser") - wizard "Advanced configuration" button -> "Advanced" (newaccountwizardcontroller.cpp:66) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Review — UI label corrections in
|
| Old (wrong) | New (correct) | Source verified |
|---|---|---|
| Launch on System Startup | Start on Login | src/gui/generalsettings.ui:55 <string>Start on Login</string> |
| Copy to clipboard | Copy | src/gui/commonstrings.cpp:44 copyToClipBoard() → tr("Copy") |
| Show file in browser | Show in <file manager> |
src/gui/commonstrings.cpp:34 tr("Show in %1").arg(fileBrowser()) (Explorer/Finder/"file manager"); confirmed distinct from tr("Show in web browser") at :39 |
| Advanced configuration (button) | Advanced | src/gui/newaccountwizard/newaccountwizardcontroller.cpp:66 setButtonText(..., tr("Advanced")) |
The old strings do not exist in the client source; the new ones are the real, current strings. The "Show in Finder" fix also correctly disambiguates from the separate Show in web browser action, and the parenthetical clarifying the per-OS label is a good touch.
AsciiDoc: clean — btn:[Advanced], menu:mouse[...], and menu:Show in Explorer[] / menu:Show in Finder[] macros are valid; the untouched xref:vfs.adoc#limitations[...] is preserved. Both CI checks (Build documentation, lint) pass.
Note: this is byte-identical to the 7.1 counterpart #759 — consistent. Repo has no changelog mechanism (n/a). One nit only: the PR body cites the Advanced source as src/gui/... but it lives under src/gui/newaccountwizard/ — the string itself is exact, so this is cosmetic.
Auto-merge: N/A (agent-authored PR; self-approval is blocked).
🤖 Automated PR review by Claude Code review agent.
dj4oC
left a comment
dj4oC
left a comment
There was a problem hiding this comment.
Corrects four UI control labels in using.adoc ("Advanced", "Copy", "Start on Login", "Show in ") to match client 7.1, per the master/7.1 pair (#759).
Findings
Accuracy: matches the paired PR's citations; not independently re-verified against owncloud/client (out of this agent's repo scope). Formatting nit (non-blocking): the "Show in Finder" rewrite for the Linux/macOS bullet cites "Show in Explorer" as one of the two examples, but Explorer is Windows-specific — worth double-checking that example still makes sense in a Linux/macOS-only sentence. No broken links.
Verdict
Approved
🤖 Automated review by Claude Code
Generated by Claude Code
2 participants
master counterpart of #759. Corrects four control labels to match client 7.1: Start on Login (not Launch on System Startup), Copy (not Copy to clipboard), Show in (not Show file in browser), and the wizard btn:[Advanced] (not Advanced configuration).
🤖 Generated with Claude Code