Skip to content

docs: correct UI labels in using.adoc (7.1)#759

Open
DeepDiver1975 wants to merge 1 commit into
7.1from
fix/using-ui-labels-7.1
Open

docs: correct UI labels in using.adoc (7.1)#759
DeepDiver1975 wants to merge 1 commit into
7.1from
fix/using-ui-labels-7.1

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Member

Summary

Four control labels in using.adoc did not match client 7.1:

Docs (before) Client 7.1 (actual) Source
Launch on System Startup Start on Login generalsettings.ui:55
Copy to clipboard Copy commonstrings.cpp:44
Show file in browser Show in <file manager> (e.g. Show in Explorer/Finder) commonstrings.cpp:32-34
Advanced configuration (button) Advanced newaccountwizardcontroller.cpp:66

The "Show file in browser" fix also disambiguates from the separate Show in web browser action.

Source of truth

owncloud/client @ 7.1.

🤖 Generated with Claude Code

Several control labels did not match client 7.1:
- "Launch on System Startup" -> "Start on Login" (generalsettings.ui:55)
- activity "Copy to clipboard" -> "Copy" (commonstrings.cpp:44)
- activity "Show file in browser" -> "Show in <file manager>"
  (commonstrings.cpp:32-34; distinct from "Show in web browser")
- wizard "Advanced configuration" button -> "Advanced"
  (newaccountwizardcontroller.cpp:66)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975

Copy link
Copy Markdown
Member Author

Review — UI label corrections in using.adoc (7.1)

Verdict: Approve (clean) — verified against owncloud/client @ 7.1 source.

The four-row table in the PR body is accurate. I independently confirmed each string against the client source on the 7.1 branch:

  • Start on Loginsrc/gui/generalsettings.ui:55 ✓ (no "Launch on System Startup" exists)
  • Copysrc/gui/commonstrings.cpp:44 copyToClipBoard()tr("Copy")
  • Show in <file manager>src/gui/commonstrings.cpp:34 tr("Show in %1").arg(fileBrowser()) ✓, correctly distinct from tr("Show in web browser") (:39)
  • Advancednewaccountwizardcontroller.cpp:66 setButtonText(..., tr("Advanced")) ✓ (actual path is src/gui/newaccountwizard/, vs src/gui/ cited in body — cosmetic, the string is exact)

AsciiDoc is clean (valid btn:/menu: macros, preserved xref). The diff is byte-identical to the master PR #760 — fully consistent across branches. lint check passes. Repo has no changelog mechanism (n/a).

Auto-merge: N/A (agent-authored PR; self-approval is blocked).

🤖 Automated PR review by Claude Code review agent.

@dj4oC dj4oC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.1 counterpart of #760 — same four UI label corrections in using.adoc.

Findings

Diff matches the master PR (#760) in substance. Same non-blocking formatting nit carries over: the Linux/macOS "Show in Finder" bullet also references "Show in Explorer" as an example, which is a Windows-only label — worth a second look. No broken links; not independently re-verified against owncloud/client (out of scope here).

Verdict

Approved

🤖 Automated review by Claude Code


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants