Skip to content

chore: Fixed remaining code after depr 36108 schedule grading cleanup#38629

Open
irfanuddinahmad wants to merge 1 commit into
masterfrom
iahmad/DEPR-36108-schedule-grading-cleanup
Open

chore: Fixed remaining code after depr 36108 schedule grading cleanup#38629
irfanuddinahmad wants to merge 1 commit into
masterfrom
iahmad/DEPR-36108-schedule-grading-cleanup

Conversation

@irfanuddinahmad
Copy link
Copy Markdown
Contributor

@irfanuddinahmad irfanuddinahmad commented May 11, 2026

This pull request removes legacy Backbone models, collections, and related tests that are no longer used in the codebase, as well as updates the test suite configuration to reflect these deletions. The main focus is on cleaning up outdated course settings and grading policy code.

Removed legacy models and collections:

  • Deleted the course_details Backbone model, which handled course metadata and validation logic. (cms/static/js/models/settings/course_details.js)
  • Removed the course_grader collection, which previously managed grading-related models. (cms/static/js/collections/course_grader.js)
  • Deleted the course_grading_policy Backbone model, which managed grading policy logic and validation. (cms/static/js/models/settings/course_grading_policy.js)

Removed related tests and updated test configuration:

  • Removed the test file for course grading policy settings. (cms/static/js/spec/models/settings_grading_spec.js)
  • Updated the test suite configuration in main.js to remove references to deleted spec files. (cms/static/cms/js/spec/main.js) [1] [2]

Related PRs:
#38417
#38418

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/DEPR-36108-schedule-grading-cleanup branch from 0930fbe to 08ca76f Compare May 11, 2026 08:20
@irfanuddinahmad irfanuddinahmad changed the title Iahmad/depr 36108 schedule grading cleanup fix: Fixed remaining code after depr 36108 schedule grading cleanup May 11, 2026
@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/DEPR-36108-schedule-grading-cleanup branch 2 times, most recently from 52f2e27 to 467f9c8 Compare May 11, 2026 11:15
…ages

Remove JS models, views, spec files, and Underscore templates that were
exclusively used by the legacy Grading and Schedule Details pages, which
were dropped in prior commits.

This work is part of #36108

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/DEPR-36108-schedule-grading-cleanup branch from 467f9c8 to 9a3e044 Compare May 11, 2026 12:43
@irfanuddinahmad irfanuddinahmad changed the title fix: Fixed remaining code after depr 36108 schedule grading cleanup chore: Fixed remaining code after depr 36108 schedule grading cleanup May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant