feat: Drop support for the legacy Grading page.#38418
Merged
Merged
Conversation
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
from
4d6e343 to
a560b9c
Compare
irfanuddinahmad
changed the title
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
6 times, most recently
from
502aede to
b729f4d
Compare
52 tasks
irfanuddinahmad
added
the
create-sandbox
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
4 times, most recently
from
a4d684b to
4e2c6bf
Compare
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
4 times, most recently
from
3313068 to
6701e88
Compare
salman2013
approved these changes
May 7, 2026
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
from
6701e88 to
a97f9a2
Compare
The legacy Grading page in Studio has been replaced with a new view in the Authoring MFE. This change removes the now unused JS/HTML/Python related to the old page. This work is part of #36108 BREAKING CHANGE: The 'legacy_studio.grading' waffle flag will no longer be respected. The system will behave as if the flag is set to false permanently.
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
from
a97f9a2 to
26f3d14
Compare
… dedicated redirect test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lper, inline explicit redirect assertion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feanil
reviewed
May 8, 2026
| % for template_name in ["course_grade_policy", "course_grade_cutoff"]: | ||
| <script type="text/template" id="${template_name}-tpl"> | ||
| <%static:include path="js/${template_name}.underscore" /> | ||
| </script> |
Contributor
There was a problem hiding this comment.
@irfanuddinahmad there are underscore templates related to this view that should also be cleaned up if they're not used by other pages. Can you do that in a followup PR in this case and for any other PRs that have landed.
Contributor
Author
There was a problem hiding this comment.
@irfanuddinahmad there are underscore templates related to this view that should also be cleaned up if they're not used by other pages. Can you do that in a followup PR in this case and for any other PRs that have landed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the legacy grading settings page and its supporting code from the codebase. The grading settings are now handled exclusively by the new grading page, and all references, templates, and JavaScript for the old implementation have been deleted.
Removal of legacy grading settings page:
settings_graders.htmltemplate, which previously rendered the legacy grading settings UI.settings_graders.jsfactory and its dependencies, eliminating the JavaScript logic for the old grading settings page.Backend code cleanup:
course.py, including theuse_new_grading_pagetoggle andget_course_gradingimport.grading_handlerview to always redirect to the new grading page, removing the conditional logic and legacy rendering path.Testing:
302 redirect on test page
🤖 Generated with Claude Code