Netlist synthesizer#654
Closed
desmonddak wants to merge 85 commits into
Closed
Conversation
Contributor
Author
|
Note that I moved examples into lib/src to enable them to be used as part of tests. The example directory has the outer main and tests for these examples. |
…al/instance naming routine names
Introduces a singleton service registry (ModuleServices) that provides a unified query surface for DevTools and inspection tools. Module.build() now registers the root module with ModuleServices.instance. Also adds SvService which wraps SystemVerilog synthesis and registers with ModuleServices for DevTools access to SV metadata. This is a clean separation: no netlist code is included. The netlist branch will later extend ModuleServices with a netlistService field.
Adds a complete netlist synthesis pipeline that converts ROHD module hierarchies into Yosys-compatible JSON netlists. Key additions: - NetlistSynthesizer: traverses module hierarchy producing cell/wire JSON - NetlistService: async factory that registers with ModuleServices - NetlistOptions: configurable post-processing passes (DCE, struct grouping, concat collapsing, etc.) - NetlistPasses: optimization and structural transformations - LeafCellMapper: maps ROHD gates to standard cell definitions - NetlistUtils: wire naming, bit-range formatting, JSON helpers Also extends Module.build() with optional netlistOptions parameter, updates ModuleServices with netlistService field, and refactors examples into lib/src/examples/ for reuse in tests. Comprehensive test coverage across 11 new/updated test files (146 tests).
Introduces a singleton service registry (ModuleServices) that provides a unified query surface for DevTools and inspection tools. Module.build() now registers the root module with ModuleServices.instance. Also adds SvService which wraps SystemVerilog synthesis and registers with ModuleServices for DevTools access to SV metadata. This is a clean separation: no netlist code is included. The netlist branch will later extend ModuleServices with a netlistService field.
Adds a complete netlist synthesis pipeline that converts ROHD module hierarchies into Yosys-compatible JSON netlists. Key additions: - NetlistSynthesizer: traverses module hierarchy producing cell/wire JSON - NetlistService: async factory that registers with ModuleServices - NetlistOptions: configurable post-processing passes (DCE, struct grouping, concat collapsing, etc.) - NetlistPasses: optimization and structural transformations - LeafCellMapper: maps ROHD gates to standard cell definitions - NetlistUtils: wire naming, bit-range formatting, JSON helpers Also extends Module.build() with optional netlistOptions parameter, updates ModuleServices with netlistService field, and refactors examples into lib/src/examples/ for reuse in tests. Comprehensive test coverage across 11 new/updated test files (146 tests).
# Conflicts: # lib/src/diagnostics/module_services.dart # lib/src/synthesizers/systemverilog/sv_service.dart # lib/src/synthesizers/utilities/synth_module_definition.dart # lib/src/synthesizers/utilities/synth_sub_module_instantiation.dart # lib/src/utilities/namer.dart # test/module_services_test.dart
# Conflicts: # lib/src/synthesizers/utilities/synth_module_definition.dart # lib/src/synthesizers/utilities/synth_sub_module_instantiation.dart # lib/src/utilities/namer.dart
# Conflicts: # lib/src/synthesizers/utilities/synth_module_definition.dart
# Conflicts: # lib/src/synthesizers/utilities/synth_module_definition.dart
# Conflicts: # tool/gh_codespaces/install_dart.sh
# Conflicts: # tool/gh_codespaces/install_dart.sh
Uses dart:io (File, Directory, Process) which requires the Dart VM. Matches the pattern used in wave_dumper_test.dart and vcd_parser_test.dart.
…in central_naming instanceNameOf and _instanceNames were added here independently, with incidental trailing-comma removals. central_naming is now the canonical home for both; revert namer.dart to match central_naming exactly.
…ming
- namer.dart: update docstring ('allocateName' → 'instanceNameOf');
_instanceNames and instanceNameOf method are identical to central_naming
- naming_consistency_test: update comment and add 'stable across repeated
definitions' test — both moved to central_naming where they belong
Introduce ModuleService/OutputService/CodegenService base types and replace the leaky ModuleServices singleton (per-service getters and inspection interfaces) with a generic register<T>/lookup<T> registry keyed by service type. SvService now extends CodegenService, exposes a stable cached synthOutput, and registers itself via the new registry. WaveformService registers as a ModuleService. Rewrites module_services_test.dart to the new API.
# Conflicts: # lib/rohd.dart # lib/src/diagnostics/module_services.dart # lib/src/synthesizers/systemverilog/sv_service.dart # test/module_services_test.dart
Defer deprecation of Module.generateSynth so simcompare need not migrate per-branch; keeps simcompare.dart matching base and removes a recurring cross-branch merge conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This is a netlist synthesizer that uses central naming to match the names of our SystemVerilog synthesizer but outputs in the Yosys JSON format for external use.
Also added are examples, pushed into lib/src so that we can access them with tests.
One exhaustive example is filter_bank which has all elements of ROHD included.
Related Issue(s)
This PR includes all changes from PR #652, so we should merge that first to be clean.
Testing
Netlist tests are included using the examples.
Backwards-compatibility
No.
Documentation
Yes, it is a new capability. Basic documentation is in
architecture.mdand in one of the tutorials.