Open
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
SHession
commented
May 6, 2026
| const supportsAudio = | ||
| sources.some((source) => source.hasAudio) && !isCinemagraph; | ||
|
|
||
| const sendOphanTrackingEvent = useCallback( |
Contributor
Author
There was a problem hiding this comment.
This is a small refactor to make sending the new tracking events simpler.
SHession
force-pushed
the
sh/bump-ophan-tracking-dependencies
branch
from
c4caaba to
1435a56
Compare
abeddow91
reviewed
May 7, 2026
| return undefined; | ||
| } | ||
|
|
||
| if (await hasMinimumBridgetVersion('8.9.2')) { |
Contributor
There was a problem hiding this comment.
This will make sure that app clients without the necessary Bridget version will not receive events that can't be understood.
abeddow91
approved these changes
May 7, 2026
Contributor
abeddow91
left a comment
abeddow91
left a comment
There was a problem hiding this comment.
This looks great! Thanks for adding a Bridget version check to prevent the client from receiving events it can't understand.
SHession
force-pushed
the
sh/bump-ophan-tracking-dependencies
branch
from
1435a56 to
f81be55
Compare
SHession
force-pushed
the
sh/bump-ophan-tracking-dependencies
branch
from
f81be55 to
c06f80f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds support for the new media events added to the Ophan data model. Bumping the Ophan Tracker JS library which provides typing, and the latest Bridget changes.
Note
I'm not sure how other platforms will handle seeing new event types if they are out-of-date. Is this something to be concerned about?
Why?
This will facilitate the tracking of new media events for self hosted video, namely: