Track mute and unmute media events for the self hosted video player#15815
Open
SHession wants to merge 7 commits intosh/bump-ophan-tracking-dependenciesfrom
Open
Track mute and unmute media events for the self hosted video player#15815SHession wants to merge 7 commits intosh/bump-ophan-tracking-dependenciesfrom
SHession wants to merge 7 commits intosh/bump-ophan-tracking-dependenciesfrom
Conversation
SHession
changed the title
SHession
changed the title
SHession
force-pushed
the
sh/bump-ophan-tracking-dependencies
branch
from
c4caaba to
1435a56
Compare
SHession
force-pushed
the
sh/send-self-hosted-player-mute-interaction-events
branch
from
6f9c7eb to
6caa8d0
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
reviewed
May 7, 2026
| }, | ||
| [playerState, isMuted, sendOphanTrackingEvent], | ||
| ); | ||
|
|
abeddow91
approved these changes
May 7, 2026
SHession
force-pushed
the
sh/bump-ophan-tracking-dependencies
branch
from
1435a56 to
f81be55
Compare
SHession
force-pushed
the
sh/bump-ophan-tracking-dependencies
branch
from
f81be55 to
c06f80f
Compare
domlander
approved these changes
May 7, 2026
Contributor
domlander
left a comment
domlander
left a comment
There was a problem hiding this comment.
A great step to improving our video tracking 🎉
| [isWeb, isApps, atomId, ophanVideoStyle], | ||
| ); | ||
|
|
||
| const mutePlayer = useCallback( |
Contributor
There was a problem hiding this comment.
I think a name like setMutedState or similar might make calls to this function easier to read.
I also might be tempted to use named arguments here to make calls to this function even clearer to read without having to check the implementation, but will leave up to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This change submits tracking events when self-hosted video mutes or unmuted via user interaction.
Note
This does not include when a video is muted by a non explicit user action e.g. scrolling the video out of view.
Why?
This will allow us to gather data about user interactions with the self hosted media player, following on from #15804.
Testing
I have tested this change across Chrome, Firefox and Safari.