Skip to content

ref: Stop returning StreamedSpan from get_start_span_function() #6560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 1 commit into from
Jun 12, 2026
+0 −7
Merged

ref: Stop returning StreamedSpan from get_start_span_function() #6560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions sentry_sdk/ai/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

import sentry_sdk
from sentry_sdk.traces import StreamedSpan
from sentry_sdk.tracing_utils import has_span_streaming_enabled
from sentry_sdk.utils import logger

MAX_GEN_AI_MESSAGE_BYTES = 20_000 # 20KB
Expand Down Expand Up @@ -538,13 +537,7 @@ def normalize_message_roles(messages: "list[dict[str, Any]]") -> "list[dict[str,


def get_start_span_function() -> "Callable[..., Any]":
if has_span_streaming_enabled(sentry_sdk.get_client().options):
return sentry_sdk.traces.start_span
Comment on lines -541 to -542

@sentrivana sentrivana Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need this part? Without it we're only using non-streaming APIs in this function

@sentrivana sentrivana Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or are we simply not using the helper in a streaming context anymore?

@alexander-alderman-webb alexander-alderman-webb Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the plan is to drop the wrapper in span streaming branches.
And after #6404 is merged it won't be used when span streaming is enabled.


current_span = sentry_sdk.get_current_span()
if isinstance(current_span, StreamedSpan):
# mypy
return sentry_sdk.traces.start_span

transaction_exists = (
current_span is not None and current_span.containing_transaction is not None
Comment thread
alexander-alderman-webb marked this conversation as resolved.
Expand Down
Loading