ref: Stop returning StreamedSpan from get_start_span_function()#6560
Open
alexander-alderman-webb wants to merge 1 commit into
Open
ref: Stop returning StreamedSpan from get_start_span_function()#6560alexander-alderman-webb wants to merge 1 commit into
StreamedSpan from get_start_span_function()#6560alexander-alderman-webb wants to merge 1 commit into
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ 89411 passed | ⏭️ 6013 skipped | Total: 95424 | Pass Rate: 93.7% | Execution Time: 304m 6s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2397 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.81% 89.78% -0.03%
==========================================
Files 192 192 —
Lines 23460 23455 -5
Branches 8062 8058 -4
==========================================
+ Hits 21069 21058 -11
- Misses 2391 2397 +6
- Partials 1328 1328 —Generated by Codecov Action |
sentrivana
reviewed
Jun 12, 2026
Comment on lines
-541
to
-542
| if has_span_streaming_enabled(sentry_sdk.get_client().options): | ||
| return sentry_sdk.traces.start_span |
Contributor
There was a problem hiding this comment.
Don't we still need this part? Without it we're only using non-streaming APIs in this function
Contributor
There was a problem hiding this comment.
Or are we simply not using the helper in a streaming context anymore?
Contributor
Author
There was a problem hiding this comment.
Yes the plan is to drop the wrapper in span streaming branches.
And after #6404 is merged it won't be used when span streaming is enabled.
sentrivana
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new
start_span()API automatically promotes spans to segment spans if applicable.There is no need for
get_start_span_function()anymore.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)