Cap Quick Access providers at a fair share of the visible slots#4156
Merged
vogella merged 1 commit intoJul 3, 2026
Merged
Conversation
Contributor
Since the continuous relevance ranking (86a07a0) fills the limited table with the globally highest-scored entries, a single prolific provider can flood out all other categories: typing "Error" lists workspace files instead of the Error Log view, because short file names outscore the category-suffixed view label. Keep the relevance ranking, but cap each provider at its fair share of the visible slots and give slots a provider does not use to the best remaining entries, so strong matches from every category stay visible. Fixes eclipse-platform#4155
iloveeclipse
force-pushed
the
lv/quickaccess-provider-fairness
branch
from
da6bf8b to
dd80ce4
Compare
Member
|
#4157 was merged, I've just rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the relevance-ranking rework, the limited Quick Access table is filled with the globally highest-scored entries, so a single prolific provider can flood out every other category. Typing "Error" in an SDK workspace listed lots of workspace files instead of the Error Log view, because short file names outscore the category-suffixed view label. This keeps the relevance ranking but caps each provider at its fair share of the visible slots; slots a provider does not use go to the best remaining entries. That restores the provider diversity of the previous round-robin fill while relevance still orders entries within each category. The selection helper is pure and covered by new unit tests in QuickAccessMatchingTest, and QuickAccessDialogTest passes unchanged.
Fixes #4155