Skip to content

Keep OS high contrast colors instead of forcing the default theme #4149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 2 commits into from
Jul 2, 2026
+9 −4
Merged

Keep OS high contrast colors instead of forcing the default theme #4149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b788090
Keep OS high contrast colors instead of forcing the default theme
vogella Jul 1, 2026
c1f6534
Increase version of org.eclipse.e4.ui.workbench.swt
vogella Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...eclipse.e4.ui.css.swt.theme/src/org/eclipse/e4/ui/css/swt/internal/theme/ThemeEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,12 @@ public void setTheme(String themeId, boolean restore) {
return;
}
}
// Theme not found (e.g. it was uninstalled); fall back to default
// In OS high-contrast mode keep the native OS colors instead of forcing a theme
if (display != null && display.getHighContrast()) {
ILog.of(ThemeEngine.class)
.warn("Theme '" + themeId + "' not found; using OS high contrast colors."); //$NON-NLS-1$ //$NON-NLS-2$
return;
}
ILog.of(ThemeEngine.class)
.warn("Theme '" + themeId + "' not found; falling back to default theme."); //$NON-NLS-1$ //$NON-NLS-2$
if (!E4_DEFAULT_THEME_ID.equals(themeId)) {
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-SymbolicName: org.eclipse.e4.ui.workbench.swt;singleton:=true
Bundle-Version: 0.18.100.qualifier
Bundle-Version: 0.18.200.qualifier
Bundle-Name: %pluginName
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
4 changes: 2 additions & 2 deletions ...lipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/E4Application.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ private void setCSSContextVariables(IApplicationContext applicationContext, IEcl
context.set(E4Application.THEME_ID, DEFAULT_THEME_ID);
}
} else {
// Check if user has overridden the branding/command-line theme
String userThemeId = getProductScopedThemeId();
// Do not let a product/workspace default override the OS high-contrast theme
String userThemeId = highContrastMode ? null : getProductScopedThemeId();
if (userThemeId != null) {
context.set(E4Application.THEME_ID, userThemeId);
} else {
Expand Down
Loading