Keep OS high contrast colors instead of forcing the default theme#4149
Merged
vogella merged 2 commits intoJul 2, 2026
Merged
Conversation
Contributor
When the OS runs in high contrast mode, Eclipse selects the high-contrast theme id. That theme was removed in the 2025-09 release, so the id is no longer found. Since eclipse-platform#3854 the theme engine then forced the default (light) theme and a product/workspace default could override the high-contrast selection, which overrode the native OS high-contrast colors and left the UI unusable (mostly white). The theme engine now keeps the native OS colors instead of falling back to the default theme while the OS is in high contrast mode, and the product/workspace default no longer overrides the high-contrast theme. The fallback and default-theme behavior are unchanged outside high contrast mode. Fixes eclipse-platform#3095
vogella
force-pushed
the
lv/high-contrast-os-theme-3095
branch
from
8e947c2 to
b788090
Compare
Contributor
Author
|
No auto-commit for the version increase, might be temporary not working. I add one manually. |
HeikoKlare
approved these changes
Jul 1, 2026
HeikoKlare
left a comment
HeikoKlare
left a comment
Contributor
There was a problem hiding this comment.
The change looks sound to me and it works fine on Windows (i.e., restores the high contrast behavior from 2026-03 and below):
Thank you for the immediate fix.
The high-contrast fix changes E4Application in org.eclipse.e4.ui.workbench.swt, whose version was not yet increased in this development stream, so bump its service segment to satisfy the version baseline check.
vogella
force-pushed
the
lv/high-contrast-os-theme-3095
branch
from
2e8d44b to
c1f6534
Compare
Contributor
Author
Based on your analysis @HeikoKlare the fix was trivial to implement. Thank you for that. I plan to merge this tomorrow (if build is green and no one objects). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the OS is in high contrast mode Eclipse requests the high-contrast theme, but that theme was removed in the 2025-09 release. Since #3854 the theme engine then forced the default light theme, and a product or workspace default could override the selection, so the native OS high-contrast colors were lost and the UI became mostly white and unusable. This keeps the OS colors when the requested theme is missing while the OS is in high contrast mode, and no longer lets a product or workspace default override the high-contrast theme. The fallback to the default theme stays unchanged outside high contrast mode.
Fixes #3095