Skip to content

Fix CookieVisitor "Must be called on the IO thread" assertion (fixes #683) #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linesight wants to merge 1 commit into
base: cefpython147
Choose a base branch
from
Open

Fix CookieVisitor "Must be called on the IO thread" assertion (fixes #683) #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/CookieManager.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Description from upstream CEF:
| object | [CookieVisitor](CookieVisitor.md) |
| __Return__ | bool |

Visit all cookies on the IO thread. The returned cookies are ordered by
Visit all cookies on the UI thread. The returned cookies are ordered by
longest path, then by earliest creation date. Returns false if cookies
cannot be accessed.

Expand All @@ -72,7 +72,7 @@ destroyed and the `CookieVisitor` callbacks won't be called.
| object | [CookieVisitor](CookieVisitor.md) |
| __Return__ | bool |

Visit a subset of cookies on the IO thread. The results are filtered by the
Visit a subset of cookies on the UI thread. The results are filtered by the
given url scheme, host, domain and path. If |includeHttpOnly| is true
HTTP-only cookies will also be included in the results. The returned
cookies are ordered by longest path, then by earliest creation date.
Expand Down
3 changes: 2 additions & 1 deletion api/CookieVisitor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ Table of contents:
| delete_cookie_out | list[bool] |
| __Return__ | bool |

Method that will be called once for each cookie. |count| is the 0-based
Method that will be called once for each cookie. This method is called on
the UI thread. |count| is the 0-based
index for the current cookie. |total| is the total number of cookies.
Set |delete_cookie_out[0]| to True to delete the cookie currently being visited.
Return False to stop visiting cookies, True to continue. This method may
Expand Down
2 changes: 1 addition & 1 deletion examples/snippets/cookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def OnLoadingStateChange(self, browser, is_loading, **_):

class CookieVisitor(object):
def Visit(self, cookie, count, total, delete_cookie_out):
"""This callback is called on the IO thread."""
"""This callback is called on the UI thread."""
print("Cookie {count}/{total}: '{name}', '{value}'"
.format(count=count+1, total=total, name=cookie.GetName(),
value=cookie.GetValue()))
Expand Down
2 changes: 1 addition & 1 deletion src/cookie.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ cdef public cpp_bool CookieVisitor_Visit(
cdef PyCookie pyCookie
cdef list pyDeleteCookie = [False]
try:
assert IsThread(TID_IO), "Must be called on the IO thread"
assert IsThread(TID_UI), "Must be called on the UI thread"
pyCookieVisitor = GetPyCookieVisitor(cookieVisitorId)
pyCookie = CreatePyCookie(cookie)
if pyCookieVisitor:
Expand Down