Fix CookieVisitor "Must be called on the IO thread" assertion (fixes #683)#693
Open
linesight wants to merge 1 commit into
Open
Fix CookieVisitor "Must be called on the IO thread" assertion (fixes #683)#693linesight wants to merge 1 commit into
linesight wants to merge 1 commit into
Conversation
…ixes cztomczak#683) CEF runs the cookie visitor callback on the UI thread, not the IO thread (ExecuteVisitor in cookie_manager_impl.cc is posted to CEF_UIT). The CookieVisitor_Visit assertion still required TID_IO, so every cookie visit raised "AssertionError: Must be called on the IO thread". Update the assert to TID_UI and fix the related API docs and example docstring that referred to the IO thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #683
Update the assert to TID_UI and fix the related API docs and example docstring that referred to the IO thread.