Disable filter use for retrieving active help requests#7
Open
joelsiks wants to merge 2 commits into
Open
Conversation
Contributor
|
What problem are you trying to solve with this PR? I know that the filtering is buggy, but we really would not like to hand out more data than needed. Is it a generic improvement, or has it caused a known issue? Preferably we still would use the filtering and then maybe fix up the value manually before converting to JSON? Best would be of course not to use a broken library... |
Contributor
|
@EliasC what's your take on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter used on pending help requests should be disabled because it does not compute correct values for certain boolean values of users (
needsProfilePicfor example). This PR disables the filter and return unfiltered pending requests instead, which is very much similar to what was done in commit 00166c0 to prevent wrong values being used.With this change, the correct value for
needsProfilePic(among others) is computed correctly and can be used in the client to determine whether to render a profile picture in certain scenarios for example.Specifically for
needsProfilePicI've also added it to the filter in case it is added back in the future.