Show students' profile pictures on help/demonstrate tables#8
Open
joelsiks wants to merge 1 commit into
Open
Conversation
joelsiks
changed the title
Author
|
The issue in the backend is (temporarily) fixed in bubify/bubify-backend#7. |
Contributor
|
Thank you @joelsiks for your PR. Sorry for not getting back to you but my notifications seems to be messed up so I was not aware of your PR. Will look at this asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this PR is for teachers/TA's to be able to see profile pictures of students in both the help and demonstrable tables.
I renamed the old
ClaimedBycomponent toUserProfileto indicate that it can be used for other purposes as well. I have tested that this works as inteded for both help and demonstrable tables given that the user has a profile picture. However, there seems to be an issue with the backend that the flagneedsProfilePicis set tofalseeven though the user does not need a profile picture.