Skip to content

fix: guard integration test resource names against 63-char API limit #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 2 commits into from
Apr 16, 2026
+15 −3
Merged

fix: guard integration test resource names against 63-char API limit #729

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b85a7b
fix: increase random suffix length in integration test resource names
vdusek Apr 15, 2026
cb6fe9b
fix: add 63-char API name limit guard to get_random_resource_name
vdusek Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions tests/integration/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,21 @@ def get_random_string(length: int = 10) -> str:
return ''.join(secrets.choice(string.ascii_letters) for _ in range(length))


def get_random_resource_name(resource: str) -> str:
"""Generate a random resource name for test resources."""
return f'python-client-test-{resource}-{get_random_string(5)}'
def get_random_resource_name(label: str) -> str:
"""Generate a unique resource name containing the given label.

Ensures the generated name does not exceed the API limit of 63 characters.
"""
name_template = 'python-client-test-{}-{}'
template_length = len(name_template.format('', ''))
api_name_limit = 63
random_id_length = 8
label_length_limit = api_name_limit - template_length - random_id_length

label = label.replace('_', '-')
assert len(label) <= label_length_limit, f'Max label length is {label_length_limit}, but got {len(label)}'

return name_template.format(label, get_crypto_random_object_id(random_id_length))


@overload
Expand Down