fix: guard integration test resource names against 63-char API limit#729
Merged
fix: guard integration test resource names against 63-char API limit#729
Conversation
The schedule integration test was flaky due to name collisions with stale resources left over from previous CI runs that were cancelled before cleanup. Increasing the random suffix from 5 to 16 characters makes such collisions virtually impossible. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
vdusek
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
==========================================
+ Coverage 95.28% 95.44% +0.15%
==========================================
Files 45 45
Lines 5114 5115 +1
==========================================
+ Hits 4873 4882 +9
+ Misses 241 233 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
reviewed
Apr 16, 2026
Adopt the approach from apify-sdk-python that validates the generated resource name won't exceed the API limit of 63 characters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
changed the title
Pijukatel
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_random_resource_name, following the approach fromapify-sdk-pythontest_schedule_create_and_get[async]caused by name collisions with stale schedules from cancelled CI runsFailed CI runs
🤖 Generated with Claude Code