Skip to content

fix(users): check IdentityResult on unlock to avoid silent failure #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antosubash merged 1 commit into from
May 10, 2026
+10 −2
Merged

fix(users): check IdentityResult on unlock to avoid silent failure #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions modules/Users/src/SimpleModule.Users/Pages/Account/UnlockAccountEndpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,16 @@ static IResult InvalidLink() =>

user.LockoutEnd = null;
user.AccessFailedCount = 0;
await userManager.UpdateAsync(user);
await userManager.UpdateSecurityStampAsync(user);
var updateResult = await userManager.UpdateAsync(user);
if (!updateResult.Succeeded)
{
return InvalidLink();
}
var stampResult = await userManager.UpdateSecurityStampAsync(user);
if (!stampResult.Succeeded)
{
return InvalidLink();
}

await bus.PublishAsync(
new UserSelfUnlockedEvent(UserId.From(user.Id), user.Email ?? string.Empty)
Expand Down
Loading