fix(users): check IdentityResult on unlock to avoid silent failure#191
Merged
Conversation
UpdateAsync and UpdateSecurityStampAsync return IdentityResult; if the store fails (concurrency, persistence error), the previous code still rendered "successfully unlocked" and emitted UserSelfUnlockedEvent for an unlock that never persisted. Surface failures via the InvalidLink page instead.
Deploying simplemodule-website with
|
| Latest commit: |
14857dc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f36532ff.simplemodule-website.pages.dev |
| Branch Preview URL: | https://fix-unlock-check-identity-re.simplemodule-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnlockAccountEndpointnow checksIdentityResult.Succeededon bothUpdateAsync(clearingLockoutEnd/AccessFailedCount) andUpdateSecurityStampAsync. Previously, a store failure (concurrency, persistence error) was silently swallowed: the page rendered "Account unlocked successfully" andUserSelfUnlockedEventwas published for an unlock that never persisted.InvalidLink()page used for invalid tokens, so the user can request a fresh unlock email.Verification
/Identity/Account/Lockoutrenders the new "receive an unlock link by email" link/Identity/Account/SendUnlockEmailredirects to/SendUnlockEmailConfirmationLockoutEndcleared,AccessFailedCount=0,SecurityStamprotatedTest plan
UnlockAccountEndpoint.csfor theSucceededbranches