Add custom cop to enforce no class reopening in tests#914
Merged
juniper-shopify merged 1 commit intoJun 10, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
juniper-shopify
changed the title
dersam
approved these changes
Jun 5, 2026
| { | ||
| (const (const {nil? cbase} :ActiveSupport) :TestCase) | ||
| (const (const {nil? cbase} :Minitest) :Test) | ||
| (const {nil? cbase} :Minitest) |
Contributor
There was a problem hiding this comment.
My understanding is that Minitest is a module, and a class can't inherit a module. In that case, wouldn't this be dead code? Or am I missing something?
LasmarKhalifa
approved these changes
Jun 8, 2026
LasmarKhalifa
left a comment
LasmarKhalifa
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Put a small comment but definitely not a blocker.
Contributor
Author
Merge activity
|
juniper-shopify
changed the base branch from
juni/Restructure_test_classes_for_better_RubyMine_compatibility
to
graphite-base/914
juniper-shopify
force-pushed
the
juni/Add_cop_to_enforce_no_reopening_classes_in_test_class_hierarchy
branch
from
525e820 to
b8bf9ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents regression on the pattern fixed in #912.