Skip to content

Restructure test classes for better RubyMine compatibility#912

Merged
juniper-shopify merged 1 commit into
mainfrom
juni/Restructure_test_classes_for_better_RubyMine_compatibility
Jun 10, 2026
Merged

Restructure test classes for better RubyMine compatibility#912
juniper-shopify merged 1 commit into
mainfrom
juni/Restructure_test_classes_for_better_RubyMine_compatibility

Conversation

@juniper-shopify

@juniper-shopify juniper-shopify commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Test classes defined like this

module Roast
  module Cogs
    class Agent < Cog
      class ConfigTest < ActiveSupport::TestCase
        ...

which re-open the Agent class (it's a class, not a module) result in some undesirable output from the RubyMine test runner.

Restructuring test classes to use the short-hand class name-spacing notation:

module Roast
  module Cogs
    class Agent::ConfigTest < ActiveSupport::TestCase
      ...

resolves the problem, since the class is not re-opened.

juniper-shopify commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@juniper-shopify juniper-shopify marked this pull request as ready for review June 2, 2026 20:42
@juniper-shopify juniper-shopify force-pushed the juni/Restructure_test_classes_for_better_RubyMine_compatibility branch from 5274811 to 323ed36 Compare June 3, 2026 15:20

juniper-shopify commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jun 10, 5:18 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 10, 5:19 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 10, 5:20 PM UTC: @juniper-shopify merged this pull request with Graphite.

@juniper-shopify juniper-shopify force-pushed the juni/Restructure_test_classes_for_better_RubyMine_compatibility branch from 323ed36 to d42f2bb Compare June 10, 2026 17:18
@juniper-shopify juniper-shopify merged commit 8d0eb3e into main Jun 10, 2026
3 checks passed
juniper-shopify added a commit that referenced this pull request Jun 10, 2026
Prevents regression on the pattern fixed in #912.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants