Restructure test classes for better RubyMine compatibility#912
Merged
juniper-shopify merged 1 commit intoJun 10, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5274811 to
323ed36
Compare
dersam
approved these changes
Jun 5, 2026
LasmarKhalifa
approved these changes
Jun 8, 2026
Contributor
Author
Merge activity
|
323ed36 to
d42f2bb
Compare
juniper-shopify
added a commit
that referenced
this pull request
Jun 10, 2026
Prevents regression on the pattern fixed in #912.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Test classes defined like this
which re-open the
Agentclass (it's a class, not a module) result in some undesirable output from the RubyMine test runner.Restructuring test classes to use the short-hand class name-spacing notation:
resolves the problem, since the class is not re-opened.