Skip to content

Enforce near-run warmups for four IBKR gateways #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 14, 2026
Merged

Enforce near-run warmups for four IBKR gateways #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions scripts/build_cloud_run_env_sync_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,15 @@ def _should_add_local_src(candidate: Path) -> bool:
"probe_time": "CLOUD_SCHEDULER_PROBE_TIME",
"precheck_time": "CLOUD_SCHEDULER_PRECHECK_TIME",
}
NEAR_RUN_WARMUP_SCHEDULE = "43 9,15 * * 1-5"
NEAR_RUN_WARMUP_SERVICES = frozenset(
{
"interactive-brokers-quant-live-u15998061-service",
"interactive-brokers-quant-live-u16608560-service",
"interactive-brokers-quant-live-u18336562-service",
"interactive-brokers-quant-live-u18308207-service",
}
)

# Strategy-derived vars: auto-populated from platform-config.json defaults.
def _derive_strategy_env_defaults(strategy_config: dict) -> dict[str, str]:
Expand Down Expand Up @@ -450,18 +459,21 @@ def _build_target_plan(
+ "\n".join(f" - {item}" for item in missing)
)

scheduler = _build_scheduler_plan(
runtime_target=runtime_target,
target=target,
defaults=defaults,
env=env,
env_values=env_values,
per_service_mode=per_service_mode,
)
_validate_near_run_warmup_schedule(service_name, scheduler)

return {
"service_name": service_name,
"strategy_profile": canonical_profile,
"env": env_values,
"scheduler": _build_scheduler_plan(
runtime_target=runtime_target,
target=target,
defaults=defaults,
env=env,
env_values=env_values,
per_service_mode=per_service_mode,
),
"scheduler": scheduler,
"remove_env_vars": sorted(set(remove_env_vars) - set(env_values)),
}

Expand Down Expand Up @@ -497,6 +509,20 @@ def _build_scheduler_plan(
return scheduler


def _validate_near_run_warmup_schedule(
service_name: str,
scheduler: Mapping[str, str],
) -> None:
if service_name not in NEAR_RUN_WARMUP_SERVICES:
return
if scheduler.get("timezone") != "America/New_York":
raise ValueError(f"{service_name} warmup timezone must be America/New_York")
if scheduler.get("probe_time") != NEAR_RUN_WARMUP_SCHEDULE:

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize two-field warmup overrides before rejecting

When one of these gateway targets uses the supported two-field scheduler override (probe_time: "43 9,15" or CLOUD_SCHEDULER_PROBE_TIME=43 9,15) with a weekday main_time, the sync workflow expands it to the same 43 9,15 * * 1-5 cron before creating the warmup job (.github/workflows/sync-cloud-run-env.yml accepts either 2 time fields or 5 cron fields). This raw exact comparison aborts the env sync before that normalization, so a configuration that would deploy the approved schedule is rejected; validate the normalized cron instead.

Useful? React with 👍 / 👎.

raise ValueError(
f"{service_name} warmup schedule must be {NEAR_RUN_WARMUP_SCHEDULE!r}"
)


def _validate_profile_inputs(
*,
service_name: str,
Expand Down
133 changes: 133 additions & 0 deletions tests/test_runtime_config_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,6 +1164,139 @@ def test_build_cloud_run_env_sync_plan_supports_per_service_targets():
assert u7654_mega["env"]["DCA_BASE_INVESTMENT_USD"] == "500"


def _four_gateway_warmup_payload(probe_time: str) -> dict[str, object]:
gateway_targets = (
(
"interactive-brokers-quant-live-u15998061-service",
"live-u15998061",
"soxl_soxx_trend_income",
True,
),
(
"interactive-brokers-quant-live-u16608560-service",
"live-u16608560",
"tqqq_growth_income",
True,
),
(
"interactive-brokers-quant-live-u18336562-service",
"live-u18336562",
"russell_top50_leader_rotation",
False,
),
(
"interactive-brokers-quant-live-u18308207-service",
"live-u18308207",
"global_etf_rotation",
False,
),
)
targets = []
for service_name, account_group, strategy_profile, enabled in gateway_targets:
targets.append(
{
"service": service_name,
"account_group": account_group,
"runtime_target_enabled": enabled,
"runtime_target": {
**json.loads(
runtime_target_json(
strategy_profile,
deployment_selector=account_group,
account_scope=account_group,
service_name=service_name,
)
),
"scheduler": {
"timezone": "America/New_York",
"main_time": "45 15 * * 1-5",
"probe_time": probe_time,
"precheck_time": "45 9 * * 1-5",
},
},
}
)

targets.append(
{
"service": "interactive-brokers-us-combo-shadow-service",
"account_group": "us-combo-shadow",
"runtime_target_enabled": False,
"runtime_target": {
**json.loads(
runtime_target_json(
"us_equity_combo_leveraged",
dry_run_only=True,
deployment_selector="us-combo-shadow",
account_scope="us-combo-shadow",
service_name="interactive-brokers-us-combo-shadow-service",
)
),
"scheduler": {
"timezone": "America/New_York",
"main_time": "45 15 * * 1-5",
"probe_time": "35 9,15 * * *",
"precheck_time": "45 9 * * *",
},
},
}
)
return {
"defaults": {
"GLOBAL_TELEGRAM_CHAT_ID": "test-chat",
"NOTIFY_LANG": "zh",
"IB_ACCOUNT_GROUP_CONFIG_SECRET_NAME": "ibkr-account-groups",
"EXECUTION_REPORT_GCS_URI": "gs://runtime/execution-reports",
},
"targets": targets,
}


def test_build_cloud_run_env_sync_plan_generates_four_gateway_near_run_warmups() -> None:
payload = _four_gateway_warmup_payload("43 9,15 * * 1-5")
result = subprocess.run(
[sys.executable, str(SYNC_PLAN_SCRIPT_PATH), "--json"],
check=True,
capture_output=True,
text=True,
env={**os.environ, "CLOUD_RUN_SERVICE_TARGETS_JSON": json.dumps(payload)},
)

plan = json.loads(result.stdout)
by_service = {target["service_name"]: target for target in plan["targets"]}
gateway_accounts = ("u15998061", "u16608560", "u18336562", "u18308207")
for account in gateway_accounts:
service_name = f"interactive-brokers-quant-live-{account}-service"
assert by_service[service_name]["scheduler"] == {
"timezone": "America/New_York",
"main_time": "45 15 * * 1-5",
"probe_time": "43 9,15 * * 1-5",
"precheck_time": "45 9 * * 1-5",
}
assert f"{service_name.removesuffix('-service')}-warmup-scheduler" == (
f"interactive-brokers-quant-live-{account}-warmup-scheduler"
)

assert by_service["interactive-brokers-us-combo-shadow-service"]["scheduler"]["probe_time"] == (
"35 9,15 * * *"
)


def test_build_cloud_run_env_sync_plan_rejects_stale_gateway_warmup_schedule() -> None:
payload = _four_gateway_warmup_payload("35 9,15 * * 1-5")
result = subprocess.run(
[sys.executable, str(SYNC_PLAN_SCRIPT_PATH), "--json"],
check=False,
capture_output=True,
text=True,
env={**os.environ, "CLOUD_RUN_SERVICE_TARGETS_JSON": json.dumps(payload)},
)

assert result.returncode != 0
assert "interactive-brokers-quant-live-u15998061-service" in result.stderr
assert "43 9,15 * * 1-5" in result.stderr


def test_build_cloud_run_env_sync_plan_requires_target_snapshot_in_per_service_mode():
payload = {
"defaults": {
Expand Down
Loading