Skip to content

Enforce near-run warmups for four IBKR gateways#344

Merged
Pigbibi merged 1 commit into
mainfrom
codex/ibkr-four-gateway-near-run-warmup
Jul 14, 2026
Merged

Enforce near-run warmups for four IBKR gateways#344
Pigbibi merged 1 commit into
mainfrom
codex/ibkr-four-gateway-near-run-warmup

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • enforce the approved 43 9,15 * * 1-5 near-run warmup contract for the four IBKR gateway services
  • reject stale ten-minute warmup configuration before Cloud Run deployment proceeds
  • cover all four gateway accounts while preserving the shadow schedule

Safety boundary

  • warmup remains authenticated GET /health
  • retryCount=2, 15–60s backoff, and attemptDeadline=60s remain unchanged
  • no /run, /dry-run, order, position, funding, leverage, HK verify, Runtime Guard, or min-instances changes

Validation

  • uv run --no-sync pytest -q tests/test_runtime_config_support.py tests/test_cloud_run_warmup_workflow.py — 76 passed
  • bash tests/test_sync_cloud_run_env_workflow.sh
  • actionlint .github/workflows/sync-cloud-run-env.yml
  • YAML parse of .github/workflows/sync-cloud-run-env.yml
  • uv run --no-sync ruff check scripts/build_cloud_run_env_sync_plan.py tests/test_runtime_config_support.py
  • git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@github-actions

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: No issues found


Review by Codex PR Review bot • PR

@Pigbibi Pigbibi merged commit aa49d42 into main Jul 14, 2026
3 checks passed
@Pigbibi Pigbibi deleted the codex/ibkr-four-gateway-near-run-warmup branch July 14, 2026 23:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 192a71bee8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

return
if scheduler.get("timezone") != "America/New_York":
raise ValueError(f"{service_name} warmup timezone must be America/New_York")
if scheduler.get("probe_time") != NEAR_RUN_WARMUP_SCHEDULE:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize two-field warmup overrides before rejecting

When one of these gateway targets uses the supported two-field scheduler override (probe_time: "43 9,15" or CLOUD_SCHEDULER_PROBE_TIME=43 9,15) with a weekday main_time, the sync workflow expands it to the same 43 9,15 * * 1-5 cron before creating the warmup job (.github/workflows/sync-cloud-run-env.yml accepts either 2 time fields or 5 cron fields). This raw exact comparison aborts the env sync before that normalization, so a configuration that would deploy the approved schedule is rejected; validate the normalized cron instead.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant