Skip to content

fix: show full command in tooltip on truncated tool rows #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MattPua wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −9
Draft

fix: show full command in tooltip on truncated tool rows #3249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions packages/ui/src/features/sessions/components/session-update/ExecuteToolView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Terminal } from "@phosphor-icons/react";
import { compactHomePath } from "@posthog/shared";
import { Tooltip } from "@posthog/ui/primitives/Tooltip";
import { useChatThreadChrome } from "../chat-thread/chatThreadChrome";
import { ToolRow } from "./ToolRow";
import {
Expand Down Expand Up @@ -51,6 +52,14 @@ export function ExecuteToolView({
);
const hasOutput = output.trim().length > 0;

// Full command in a wrapping mono block so a truncated row still surfaces
// exactly what ran on hover, however long it is.
const commandTooltip = (
<span className="block max-w-md whitespace-pre-wrap break-all font-mono text-xs">
{command}
</span>
);

return (
<ToolRow
icon={Terminal}
Expand All @@ -64,18 +73,19 @@ export function ExecuteToolView({
{command &&
(chatChrome ? (
<ToolTitle className="min-w-0 shrink truncate font-mono">
<span className="block truncate" title={command}>
{truncateText(compactHomePath(command), MAX_COMMAND_LENGTH)}
</span>
<Tooltip content={commandTooltip}>
<span className="block truncate">
{truncateText(compactHomePath(command), MAX_COMMAND_LENGTH)}
</span>
</Tooltip>
</ToolTitle>
) : (
<ToolTitle className="min-w-0 shrink truncate">
<span
className="block truncate border border-border bg-gray-5 font-mono"
title={command}
>
{truncateText(compactHomePath(command), MAX_COMMAND_LENGTH)}
</span>
<Tooltip content={commandTooltip}>
<span className="block truncate border border-border bg-gray-5 font-mono">
{truncateText(compactHomePath(command), MAX_COMMAND_LENGTH)}
</span>
</Tooltip>
</ToolTitle>
))}
</ToolRow>
Expand Down
Loading