fix: show full command in tooltip on truncated tool rows#3249
Draft
MattPua wants to merge 1 commit into
Draft
Conversation
Truncated terminal-command rows relied on the native `title` attribute, which is unreliable/absent in-app, so users couldn't see the full command. Swap it for the Tooltip primitive, rendering the full command in a wrapping mono block on hover. Generated-By: PostHog Code Task-Id: 9f618854-2b33-47b4-9c9f-81e9d196b329
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a tool's terminal command is longer than the row width it gets truncated with an ellipsis, and there was no tooltip to reveal what actually ran. It relied on the native
titleattribute, which is unreliable/absent in-app.Changes
title={command}on the truncated command row with theTooltipprimitiveHow did you test this?
pnpm --filter @posthog/ui typecheckpassesbiome checkpasses on the changed fileAutomatic notifications