Skip to content

Fix scaling for Inexorable Critical II #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peechey wants to merge 2 commits into
base: dev
Choose a base branch
from
+4 −4
Open

Fix scaling for Inexorable Critical II #1852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d043af
fix Inexorable Critical II scaling the wrong stat
Peechey May 13, 2026
6460c99
defaultState 10 for Inexorable Critical I
Peechey May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Data/Skills/sup_int.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5150,7 +5150,7 @@ skills["SupportInevitableCriticalsPlayerTwo"] = {
mod("Multiplier:InevitableCritCap", "BASE", nil),
},
["support_inevitable_criticals_critical_strike_multiplier_+%_final_per_second"] = {
mod("CritChance", "MORE", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritMultCap", limitTotal = true }),
mod("CritMultiplier", "MORE", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritMultCap", limitNegTotal = true }),
},
["support_inevitable_criticals_critical_strike_multiplier_+%_final_cap"] = {
mod("Multiplier:InevitableCritMultCap", "BASE", nil),
Expand Down
2 changes: 1 addition & 1 deletion src/Export/Skills/sup_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ statMap = {
mod("Multiplier:InevitableCritCap", "BASE", nil),
},
["support_inevitable_criticals_critical_strike_multiplier_+%_final_per_second"] = {
mod("CritChance", "MORE", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritMultCap", limitTotal = true }),
mod("CritMultiplier", "MORE", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritMultCap", limitNegTotal = true }),
},
["support_inevitable_criticals_critical_strike_multiplier_+%_final_cap"] = {
mod("Multiplier:InevitableCritMultCap", "BASE", nil),
Expand Down
4 changes: 2 additions & 2 deletions src/Modules/ConfigOptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,8 @@ local configSettings = {
{ var = "incisionConsumedRecently", type = "count", label = "# of Incisions consumed recently:", ifSkill = "Incision", apply = function(val, modList, enemyModList)
modList:NewMod("Multiplier:IncisionConsumedRecently", "BASE", val, "Config")
end },
{ label = "Inevitable Critical Support:", ifSkill = "Inevitable Critical" },
{ var = "SecondsSinceInevitableCrit", type = "count", label = "# of seconds since Inevitable crit:", ifSkill = "Inevitable Critical", tooltip = "Also implies you've crit recently if the value is 3s or below", apply = function(val, modList, enemyModList)
{ label = "Inexorable Critical Support:", ifSkill = { "Inexorable Critical I", "Inexorable Critical II" } },
{ var = "SecondsSinceInevitableCrit", type = "count", label = "# of seconds since Inevitable Crit:", ifSkill = { "Inexorable Critical I", "Inexorable Critical II" }, defaultState = 10, tooltip = "Also implies you've crit recently if the value is 3s or below", apply = function(val, modList, enemyModList)
modList:NewMod("Multiplier:SecondsSinceInevitableCrit", "BASE", val, "Config", { type = "Condition", var = "Combat" })
if val < 4 then
modList:NewMod("Condition:CritRecently", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
Expand Down
Loading