Fix scaling for Inexorable Critical II#1852
Open
Peechey wants to merge 2 commits into
Open
Conversation
fix Inexorable Critical Support config not showing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1851
Description of the problem being solved:
Inexorable Critical II had CritChance for the CritMulti scaling mod and it was using limitTotal instead of limitNegTotal so it was running m_min instead of m_max, applying 50% less always.
The configOptions for seconds since crit was also not showing as we need to match the tiers now. I have another PR where I introduce GemFamily which could be used here but it's only two skills so using SkillName and a list isn't bad either.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: