fix(auth): harden callback relay registration retries#60
Merged
Conversation
… retry The 1s registration timeout was shorter than a cold DNS+TLS handshake on a fresh process, producing a "timeout of 1000ms exceeded" loop on /login. Bumped to 5s and replaced the linear retry withTransientRetry (3 attempts, 200ms exponential + jitter, transient-only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #55 with the same callback-relay reliability fix plus explicit retry-boundary coverage.
The callback-relay registration POST used a 1000ms timeout, which can be shorter than cold DNS/TLS on a fresh process. This moves retry behavior into
registerOauthCallbackRelay, raises the service-level registration budget to 5000ms, and retries only transient registration failures.Behavior
Validation
Focused OAuth tests:
Result:
17 pass, 0 fail.Auth suite:
Result:
457 pass, 0 fail.Notes
This keeps the spirit of #55 but tightens the retry classifier. Non-Axios errors are not retried, because those are more likely programming or invariant failures than transient network failures.