fix(auth): widen callback-relay registration budget and add transient retry#55
Closed
andomeder wants to merge 1 commit into
Closed
fix(auth): widen callback-relay registration budget and add transient retry#55andomeder wants to merge 1 commit into
andomeder wants to merge 1 commit into
Conversation
… retry The 1s registration timeout was shorter than a cold DNS+TLS handshake on a fresh process, producing a "timeout of 1000ms exceeded" loop on /login. Bumped to 5s and replaced the linear retry withTransientRetry (3 attempts, 200ms exponential + jitter, transient-only).
Contributor
|
Thanks for the fix. I took the same callback-relay timeout/retry direction and opened an upstream-owned replacement PR with additional retry-boundary tests: #60. The extra test coverage pins:
Validation on #60:
I recommend treating #60 as the merge candidate and closing this PR once #60 lands. |
Contributor
|
Closed as superseded by #60, which keeps the same callback-relay retry direction but adds explicit retry/non-retry coverage and has passing CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback-relay registration POST ran with a 1000ms axios timeout,
shorter than a cold DNS+TLS handshake on a fresh process. After 3 attempts
a user saw "timeout of 1000ms exceeded" and pressed Enter repeatedly until
the socket warmed up.
Raise the budget to 5000ms and replace the linear 150*attempt loop with
withTransientRetry: 3 attempts, 200ms base, exponential backoff plus jitter.
The wrapper only retries transient errors (network failures, 5xx, 429) so
4xx responses fail fast.
Validation: bun test src/services/oauthServiceE2E.test.ts src/services/oauth/client.test.ts 18/18.