Skip to content

Use string lists for manifest search paths#1928

Open
charles-lunarg wants to merge 1 commit into
KhronosGroup:mainfrom
charles-lunarg:use_string_list_for_search_paths
Open

Use string lists for manifest search paths#1928
charles-lunarg wants to merge 1 commit into
KhronosGroup:mainfrom
charles-lunarg:use_string_list_for_search_paths

Conversation

@charles-lunarg

Copy link
Copy Markdown
Collaborator

Rather than try to combine all search paths into a single giant string, add each path to a list of strings, deduplicating as we go. This simplifies the logic to get all of the search paths by not needing to first sum up the lengths of all of the search paths in order to allocate a single large string, or having to reallocate the string if it isn't large enough.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 765074.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 765091.

@charles-lunarg

Copy link
Copy Markdown
Collaborator Author

While not an implementation, this PR will make #1401 simpler as all of the search paths are tracked individually rather than in one giant string.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3536 running.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3536 failed.

@charles-lunarg charles-lunarg force-pushed the use_string_list_for_search_paths branch from c65f0a0 to 8348e7f Compare June 8, 2026 20:04
@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 765185.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3538 running.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3538 failed.

@charles-lunarg charles-lunarg force-pushed the use_string_list_for_search_paths branch from 8348e7f to aa95552 Compare June 8, 2026 21:26
@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 765350.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 765388.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3540 running.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3540 failed.

@charles-lunarg charles-lunarg force-pushed the use_string_list_for_search_paths branch from aa95552 to 961821d Compare June 9, 2026 14:29
@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 766239.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3543 running.

@charles-lunarg charles-lunarg force-pushed the use_string_list_for_search_paths branch from 961821d to 601d69b Compare June 9, 2026 15:48
@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 766364.

Rather than try to combine all search paths into a single giant string,
add each path to a list of strings, deduplicating as we go. This
simplifies the logic to get all of the search paths by not needing to
first sum up the lengths of all of the search paths in order to allocate
a single large string, or having to reallocate the string if it isn't
large enough.
@charles-lunarg charles-lunarg force-pushed the use_string_list_for_search_paths branch from 601d69b to 9984a16 Compare June 9, 2026 16:16
@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 766443.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3546 running.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3546 aborted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants