Use a string list for manifest search paths on windows#1923
Closed
charles-lunarg wants to merge 1 commit into
Closed
Use a string list for manifest search paths on windows#1923charles-lunarg wants to merge 1 commit into
charles-lunarg wants to merge 1 commit into
Conversation
To save allocations, paths to search for manifests are combined into a single string delineated by path separators. This causes call sites to need to allocate the string if it is null and handle resizing if the path to add to the string doesn't fit. Using a string list simplifies the code substantially and makes handling out of memory conditions easier. This commit only modifies the Windows specific search paths to use a string list. Future work is needed to convert the rest of the codebase over to using a string list to store the search paths.
|
CI Vulkan-Loader build queued with queue ID 763333. |
|
CI Vulkan-Loader build queued with queue ID 763350. |
|
CI Vulkan-Loader build # 3525 running. |
|
CI Vulkan-Loader build # 3525 passed. |
Collaborator
Author
|
Closing in favor of #1928 I would rather replace all search path logic in one commit than iterate it piecemeal. I originally wrote this PR to see how practical the change was. Seeing that it was quite straightforward, applying it to the rest of the codebase was not difficult. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To save allocations, paths to search for manifests are combined into a single string delineated by path separators. This causes call sites to need to allocate the string if it is null and handle resizing if the path to add to the string doesn't fit. Using a string list simplifies the code substantially and makes handling out of memory conditions easier. This commit only modifies the Windows specific search paths to use a string list. Future work is needed to convert the rest of the codebase over to using a string list to store the search paths.