Use C size for serialization/deserialization#208
Merged
Conversation
6c74dba to
e6a5b18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new method in ByteRepr called byte_size. It is used to describe the C/C++ byte size of the object and it's used for serializatoin/deserialization through from/to_bytes.
In refcount, Rust structs have a different size than the C/C++ structs because each field is wrapped in
Value<>. For example:becomes
This difference in size breaks ByteRepr for structs. To do correct serialization we need the C/C++ size. Codegen embeds this into the generated code using the ByteRepr::byte_size method.
Then, when a reinterpreted pointer is created, ReinterpretedView::elem_byte_size saves ByteRepr::byte_size. This is an optimization so that the ByteRepr trait is not exposed to all Ptr methods, even into methods that don't have to do with reinterpreted pointers.
The goal of this is to support structs inside unions. Structs, as any other type that takes part in an union, is a reinterpreted view into the byte buffer of the union.