Memcpy a pointer to a struct through ErasedPtr#207
Merged
Conversation
lucic71
force-pushed
the
anyptr-reinterpreted
branch
from
9c5e7a8 to
1bbc6b0
Compare
lucic71
force-pushed
the
anyptr-reinterpreted
branch
from
f5adb93 to
e4bb83e
Compare
Contributor
Author
|
@nunoplopes this is ready for review |
lucic71
force-pushed
the
anyptr-reinterpreted
branch
from
4514912 to
48d6908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnyPtr::reinterpret_castwas matching against a hardcoded list of types. This PR adds ErasedPtr::as_bytes which is areinterpret_cast::<u8>so that memcpy/memset a pointer to a struct works.I also simplified the implementation for ErasedPtr::equals in this refactor.