Fix console logging in production and improve type safety

metro.config.js

@@ -2,7 +2,7 @@ const { getDefaultConfig } = require('expo/metro-config');
 
 const config = getDefaultConfig(__dirname);
 
-// Enable debug logging and better error reporting
+// Configure supported platforms for module resolution
 config.resolver.platforms = ['ios', 'android', 'native', 'web'];
 
 // Polyfill Node.js modules for React Native
@@ -24,13 +24,15 @@ config.transformer.minifierConfig = {
 config.server = {
   enhanceMiddleware: (middleware) => {
     return (req, res, next) => {
-      console.log(`[Metro] ${req.method} ${req.url}`);
+      if (process.env.NODE_ENV !== 'production') {
+        console.log(`[Metro] ${req.method} ${req.url}`);
+      }
       return middleware(req, res, next);
     };
   },
 };
 
-// Enable better error handling
+// Configure Metro transformer options for imports and inline requires
 config.transformer.getTransformOptions = async () => ({
   transform: {
     experimentalImportSupport: false,

services/rbf-service.ts

@@ -18,6 +18,13 @@
  */
 const NON_RBF_SEQUENCE = 0xFFFFFFFF;
 
+/**
+ * Minimum required fee increase (as a fraction of the original fee)
+ * to consider a replacement transaction for RBF.
+ * For example, 0.1 means a 10% minimum fee increase.
+ */
+const MIN_RBF_FEE_INCREASE_RATE = 0.1;
+
 /**
  * Validates the given ECC library by checking basic functionality.
  * Throws an error if validation fails.
@@ -36,8 +43,6 @@
   if (!publicKey || publicKey.length !== 33) {
     throw new Error('ECC point generation failed');
   }
-
-  console.log('✅ ECC library validation passed');
 }
 
 export interface RBFTransaction {
@@ -54,7 +59,7 @@
   isValid: boolean;
   canReplace: boolean;
   reason?: string;
-  originalTx?: any;
+  originalTx?: Transaction;
   utxos?: UTXO[];
 }
 
@@ -414,7 +419,7 @@
 
     // Get our inputs from the original transaction
     const walletAddressesSet = new Set(walletAddresses);
     const ourInputs = originalTx.vin?.filter((input: any) => {
       return input.prevout?.scriptpubkey_address && 
              walletAddressesSet.has(input.prevout.scriptpubkey_address);
     });
@@ -472,7 +477,7 @@
 
     // Calculate outputs (same as original transaction)
     let totalOutputValue = 0;
     for (const output of originalTx.vout) {
       // Handle different output types
       if (output.scriptpubkey_address) {
         // P2PKH, P2WPKH, P2SH outputs
@@ -493,8 +498,8 @@
     let changeOutputValue = 0;
 
     // Look for a change output (typically the last output that goes to our wallet)
     for (let i = originalTx.vout.length - 1; i >= 0; i--) {
       const output = originalTx.vout[i];
       if (output.scriptpubkey_address && walletAddressesSet.has(output.scriptpubkey_address)) {
         changeOutputIndex = i;
         changeOutputValue = output.value;
@@ -506,7 +511,7 @@
     const originalFee = totalInputValue - totalOutputValue;
 
     // Calculate the original fee rate
     const originalSize = estimateTransactionSize(ourInputs.length, originalTx.vout.length);
     const originalFeeRate = originalFee / originalSize;
 
     // Calculate the target fee based on the desired fee rate
@@ -519,7 +524,7 @@
 
     // Ensure the new fee meets RBF requirements (must be higher than original)
     // Only apply minimum increase if user's requested fee is too low
-    const minFeeIncrease = Math.ceil(originalFee * 0.1); // 10% increase minimum for RBF
+    const minFeeIncrease = Math.ceil(originalFee * MIN_RBF_FEE_INCREASE_RATE); // minimum increase for RBF
     const actualTargetFee = Math.max(targetFee, originalFee + minFeeIncrease);
 
     const feeIncrease = actualTargetFee - originalFee;
@@ -542,7 +547,7 @@
     }
 
     // Calculate actual output values and transaction size
     let actualOutputCount = originalTx.vout.length;
     let actualOutputValue: number;
     let newChangeValue = 0;
 
@@ -551,7 +556,7 @@
       newChangeValue = changeOutputValue - feeIncrease;
       if (newChangeValue <= 546) { // Dust threshold
         // Change output would be dust, remove it entirely
         actualOutputCount = originalTx.vout.length - 1;
         actualOutputValue = totalOutputValue - changeOutputValue;
         console.log(`🗑️ Removing dust change output: ${changeOutputValue} sats`);
       } else {
@@ -583,12 +588,12 @@
     }
 
     // Re-add outputs with correct values
     for (let i = 0; i < originalTx.vout.length; i++) {
       if (i === changeOutputIndex) {
         // This is the change output
         if (newChangeValue > 546) {
           // Keep the change output with adjusted value
           const output = originalTx.vout[i];
           if (output.scriptpubkey_address) {
             txb.addOutput(output.scriptpubkey_address, newChangeValue);
           } else if (output.scriptpubkey) {
@@ -598,7 +603,7 @@
         // If newChangeValue <= 546, skip this output (dust)
       } else {
         // Regular output, keep original value
         const output = originalTx.vout[i];
         if (output.scriptpubkey_address) {
           txb.addOutput(output.scriptpubkey_address, output.value);
         } else if (output.scriptpubkey) {