Fix console logging in production and improve type safety#457
Merged
Conversation
…ice.ts Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…bility Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…issues Fix console logging in production and improve type safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a few targeted improvements and refinements to the Metro bundler configuration and the Replace-By-Fee (RBF) transaction logic. The most notable changes are the addition of a configurable minimum RBF fee increase rate, improved type safety, and enhanced Metro config clarity and logging.
RBF Transaction Logic Improvements:
MIN_RBF_FEE_INCREASE_RATEconstant to define the minimum required fee increase for RBF transactions, replacing hardcoded values for better maintainability and clarity. [1] [2]RBFValidationResultinterface by specifyingoriginalTxas aTransactiontype instead ofany.Metro Bundler Configuration Enhancements: